Fixes checkout v2 integration #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Phone number: Checkout.com only accepts digits for phone numbers - COF feature: the param was being sent on the wrong place
filipebarcos
force-pushed
the
fixes-checkout-v2-integration
branch
from
71e0065 to
61436d7
Compare
elfassy
approved these changes
Jun 19, 2019
filipebarcos
force-pushed
the
fixes-checkout-v2-integration
branch
from
61436d7 to
b5f313f
Compare
elfassy
reviewed
Jun 21, 2019
| post[:source][:billing_address] = {} | ||
| post[:source][:billing_address][:address_line1] = address[:address1] unless address[:address1].blank? | ||
| post[:source][:billing_address][:address_line2] = address[:address2] unless address[:address2].blank? | ||
| post[:source][:billing_address][:city] = address[:city] unless address[:city].blank? | ||
| post[:source][:billing_address][:state] = address[:state] unless address[:state].blank? | ||
| post[:source][:billing_address][:country] = address[:country] unless address[:country].blank? | ||
| post[:source][:billing_address][:zip] = address[:zip] unless address[:zip].blank? | ||
| post[:source][:phone] = { number: address[:phone] } unless address[:phone].blank? |
Krystosterone
approved these changes
Jun 21, 2019
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
* Fixing phone number unwanted chars and COF feature - Phone number: Checkout.com only accepts digits for phone numbers - COF feature: the param was being sent on the wrong place * Stop sending phone number to Checkout V2 integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting + 2 fixes
source: { phone: { number: '' }}}field