BPoint: Hook up merchant_reference and CRN fields #3249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields were already implemented in the request structure but did not actually get anything passed to them from options. Unit: 18 tests, 59 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: No current test credentials, fairly confident the changes are safe given that the fields are already present in requests, just without a value.
jknipp
approved these changes
Jun 19, 2019
| @gateway.authorize(@amount, @credit_card, @options.merge({ crn1: 'ref' })) | ||
| end.check_request do |endpoint, data, headers| | ||
| assert_match(%r(<MerchantReference>1</MerchantReference>)m, data) | ||
| assert_match(%r(<CRN1>ref</CRN1>)m, data) |
There was a problem hiding this comment.
I'm assuming it was a deliberate decision to test a minimum number of fields here, as it's good enough testing.
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
These fields were already implemented in the request structure but did not actually get anything passed to them from options. Closes activemerchant#3249 Unit: 18 tests, 59 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: No current test credentials, fairly confident the changes are safe given that the fields are already present in requests, just without a value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields were already implemented in the request structure but did
not actually get anything passed to them from options.
Unit:
18 tests, 59 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote: No current test credentials, fairly confident the changes are
safe given that the fields are already present in requests, just without
a value.