Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adyen: Replace empty state string with N/A #3252

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Adyen: Replace empty state string with N/A #3252

merged 1 commit into from
Jul 3, 2019

Conversation

therufs
Copy link
Contributor

@therufs therufs commented Jun 21, 2019

@therufs therufs requested a review from a team June 21, 2019 20:13
@therufs therufs self-assigned this Jun 21, 2019
molbrown
molbrown reviewed Jun 21, 2019
View reviewed changes
test/remote/gateways/remote_adyen_test.rb Show resolved Hide resolved
lib/active_merchant/billing/gateways/adyen.rb
def get_state(address)
address[:state] && !address[:state].blank? ? address[:state] : 'N/A'
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@therufs therufs force-pushed the ECS-367-adyen-state-values branch from af2fd52 to 4450126 Compare June 25, 2019 15:56
@therufs
Copy link
Contributor Author

therufs commented Jun 25, 2019 •
edited
Loading

Unit tests:
38 tests, 183 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote tests:
61 tests, 187 assertions, 4 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
93.4426% passed

Fixes for failing tests anticipated pursuant to https://spreedly.slack.com/archives/CF080246R/p1561051065014400

@therufs therufs force-pushed the ECS-367-adyen-state-values branch from 4450126 to 38327b3 Compare July 2, 2019 14:26
curiousepic
curiousepic approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@curiousepic curiousepic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@therufs therufs merged commit 38327b3 into activemerchant:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molbrown molbrown molbrown left review comments

@curiousepic curiousepic curiousepic approved these changes

Assignees

@therufs therufs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@therufs @curiousepic @molbrown