Adyen: Add support for non-fractional currencies #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molbrown
force-pushed
the
ECS-420_adyen_jpy
branch
from
c41e208 to
8672986
Compare
jknipp
reviewed
Jun 26, 2019
| } | ||
| post[:modificationAmount] = amount | ||
| end | ||
|
|
||
| # temporary method in place to support Spreedly customers switching over to sending multiplied amounts for non-fractional currency transactions, as now required for localized_amount. To avoid amount manipulation, send opt_out_multiply_amount with any non-fractional currency transaction. | ||
| def what_amount(money, options) |
There was a problem hiding this comment.
Two small nitpicks, though knowing this is a temporary measure, I don't feel strongly about updating these:
- use a multi-line comment / line breaks for the long comment
what_amount->calculate_amount??
molbrown
force-pushed
the
ECS-420_adyen_jpy
branch
from
8672986 to
0a5d734
Compare
molbrown
force-pushed
the
ECS-420_adyen_jpy
branch
from
0a5d734 to
5399c0b
Compare
molbrown
commented
Jun 26, 2019
| @@ -9,6 +9,7 @@ class AdyenGateway < Gateway | |||
|
|
|||
| self.supported_countries = ['AT', 'AU', 'BE', 'BG', 'BR', 'CH', 'CY', 'CZ', 'DE', 'DK', 'EE', 'ES', 'FI', 'FR', 'GB', 'GI', 'GR', 'HK', 'HU', 'IE', 'IS', 'IT', 'LI', 'LT', 'LU', 'LV', 'MC', 'MT', 'MX', 'NL', 'NO', 'PL', 'PT', 'RO', 'SE', 'SG', 'SK', 'SI', 'US'] | |||
| self.default_currency = 'USD' | |||
| self.currencies_without_fractions = %w(CVE DJF GNF IDR JPY KMF KRW PYG RWF UGX VND VUV XAF XOF XPF) | |||
There was a problem hiding this comment.
FYI @jknipp @curiousepic I added a local override for currencies_without_fractions according to https://docs.adyen.com/development-resources/currency-codes/#description and added a CLP test to confirm intended behavior.
molbrown
force-pushed
the
ECS-420_adyen_jpy
branch
from
5399c0b to
74bae85
Compare
Adds localized_amount to determine amount, to allow correct handling of non-fractional currencies. Includes a what_amount method which will protect customers already transacting on Adyen from a sudden change in their transaction amounts. what_amount will be removed after coordinating. ECS-420 Unit: 40 tests, 191 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 60 tests, 187 assertions, 4 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.3333% passed Failures due to error message change, unrelated Closes activemerchant#3257
molbrown
force-pushed
the
ECS-420_adyen_jpy
branch
from
74bae85 to
bcd95f1
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Adds localized_amount to determine amount, to allow correct handling of non-fractional currencies. Includes a what_amount method which will protect customers already transacting on Adyen from a sudden change in their transaction amounts. what_amount will be removed after coordinating. ECS-420 Unit: 40 tests, 191 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 60 tests, 187 assertions, 4 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.3333% passed Failures due to error message change, unrelated Closes activemerchant#3257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds localized_amount to determine amount, to allow correct handling of
non-fractional currencies.
Includes a what_amount method which will protect customers already transacting on
Adyen from a sudden change in their transaction amounts. what_amount
will be removed after coordinating.
ECS-420
Unit:
40 tests, 189 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
60 tests, 187 assertions, 4 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
93.3333% passed
Failures due to error message change, unrelated