Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adyen: Remove temporary amount modification for non-fractional currencies #3263

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

molbrown
Copy link
Contributor

After safe switchover is coordinated with customer who needed
transition step during update of Adyen to use localized_amount.

Unit:
39 tests, 188 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
60 tests, 187 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Continues ECS-420

@jknipp jknipp requested a review from a team July 1, 2019 15:42
@jknipp jknipp marked this pull request as ready for review July 1, 2019 15:48
@jknipp
Copy link
Member

jknipp commented Jul 1, 2019

@activemerchant/spreedly-connect Ready for review, the customer has signed off that this code can be removed.

Copy link
Contributor

@bayprogrammer bayprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

…cies

After safe switchover is coordinated with customer who needed
transition step during update of Adyen to use localized_amount.

Unit:
39 tests, 188 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
60 tests, 187 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Continues ECS-420

closes activemerchant#3263
@jknipp jknipp force-pushed the ECS-425_adyen_cleanup branch from 4dce788 to 4509244 Compare July 1, 2019 19:41
@jknipp jknipp merged commit 4509244 into activemerchant:master Jul 1, 2019
whitby3001 pushed a commit to whitby3001/active_merchant that referenced this pull request Sep 3, 2019
…cies

After safe switchover is coordinated with customer who needed
transition step during update of Adyen to use localized_amount.

Unit:
39 tests, 188 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
60 tests, 187 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Continues ECS-420

closes activemerchant#3263
@molbrown molbrown deleted the ECS-425_adyen_cleanup branch July 1, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants