Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardConnect: Fix level 3 field parse #3273

Merged

Conversation

hdeters
Copy link
Contributor

@hdeters hdeters commented Jul 11, 2019

Remove underscores from level 3 gateway specific fields. This functionality existed but wasn't working correctly -- this PR fixes it.

ECS-397

Unit:
22 tests, 92 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Remote:
23 tests, 55 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

@hdeters hdeters requested a review from a team July 11, 2019 19:18
@hdeters hdeters self-assigned this Jul 11, 2019
Copy link
Contributor

@curiousepic curiousepic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Remove underscores from level 3 gateway specific fields

ECS-397

Unit:
22 tests, 92 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Remote:
23 tests, 55 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Closes activemerchant#3273
@hdeters hdeters force-pushed the ECS-397_cardconnect_parse_lineitems branch from 585cf46 to 1d63f42 Compare July 12, 2019 16:03
@hdeters hdeters merged commit 1d63f42 into activemerchant:master Jul 12, 2019
@hdeters hdeters deleted the ECS-397_cardconnect_parse_lineitems branch July 12, 2019 16:06
whitby3001 pushed a commit to whitby3001/active_merchant that referenced this pull request Sep 3, 2019
Remove underscores from level 3 gateway specific fields

ECS-397

Unit:
22 tests, 92 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Remote:
23 tests, 55 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Closes activemerchant#3273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants