CECAbank: Update encryption to SHA2 #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leila-alderman
commented
Jul 16, 2019
leila-alderman
commented
Jul 16, 2019
curiousepic
reviewed
Jul 16, 2019
jasonxp
reviewed
Jul 16, 2019
jasonxp
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Looks good to me. After updating core to this new AM release, we should keep an eye on Lava (https://lava.spreedly.com/gateways/cecabank/organizations/month/2019/7) to sanity check that Cecabank transactions are still going through, since the production URL has changed.
|
Good point on monitoring Lava when deploying. Get familiar with how to roll forward just in case 😄 |
Updated the encryption method for the CECAbank gateway from SHA1 to SHA2. This change also included updating the URLs for the gateway and revising the remote tests to work with the new URL. CE-23 Unit: 7 tests, 36 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 5 tests, 17 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
leila-alderman
force-pushed
the
CE-23_cecabank_sha2
branch
from
332d14e to
374a82c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the encryption method for the CECAbank gateway from SHA1 to
SHA2. This change also included updating the URLs for the gateway and
revising the remote tests.
CE-23
Unit:
7 tests, 36 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
Remote:
5 tests, 17 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed