Realex: Implement credit #3280
Merged
Realex: Implement credit #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leila-alderman
commented
Jul 17, 2019
leila-alderman
commented
Jul 17, 2019
leila-alderman
commented
Jul 17, 2019
jasonxp
reviewed
Jul 18, 2019
jasonxp
reviewed
Jul 19, 2019
jasonxp
reviewed
Jul 25, 2019
jasonxp
approved these changes
Jul 25, 2019
|
Looks good. I added one note requesting a comment to help explain the refund/rebate/credit variable/parameter naming situation for posterity. Feel free to |
after that.
leila-alderman
force-pushed
the
CE-52_realex_general_credit
branch
from
ec9ea11 to
07fdd24
Compare
molbrown
approved these changes
Jul 29, 2019
CHANGELOG
Outdated
| @@ -46,6 +46,7 @@ | |||
| * Add Kosovo to the list of countries [AnotherJoSmith] #3226 | |||
| * Realex: Adds 3DS 1&2 support through external MPI [filipebarcos] #3284 | |||
| * PayPal: Adds 3DS 1 support through external MPI [nebdil] #3279 | |||
| * Realex: Re-implement credit as general credit [leila-alderman] #3280 | |||
There was a problem hiding this comment.
Move your changelog entry up to HEAD, since this was not included in the July 26 version. (Easy to miss)
There was a problem hiding this comment.
Thanks for catching that! So grateful for your re-review!
Re-implemented the `credit` action (known as `general_credit` in Spreedly parlance) for the Realex gateway from its deprecated implementation of re-using the `refund` action to performing an actual `credit` (non-reference credit) transaction. CE-52 / CE-58 Unit: 28 tests, 975 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 27 tests, 138 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
leila-alderman
force-pushed
the
CE-52_realex_general_credit
branch
from
07fdd24 to
072e072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented support for
credit(also known asgeneral_creditinSpreedly parlance) for the Realex gateway, including remote and unit
tests.
CE-52 / CE-58
Unit:
27 tests, 844 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
Remote:
26 tests, 135 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed