Global Collect: Add Cabal card #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonxp
approved these changes
Aug 27, 2019
leila-alderman
force-pushed
the
CE-97_global_collect_add_cabal
branch
from
ec56175 to
4a5efd3
Compare
Adds the Cabal card to the Global Collect gateway (also known as the Ingenico gateway). The Ingenico gateway docs do not include a test card number for Cabal, and sending card numbers that follow the Luhn algorithm and fall within the Cabal card range results in error messages of "Rejected". Therefore, no additional remote or unit tests were added to the Global Collect gateway to test the implementation of the Cabal card type. CE-94 / CE-97 Unit: 20 tests, 88 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 17 tests, 40 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
leila-alderman
force-pushed
the
CE-97_global_collect_add_cabal
branch
from
4a5efd3 to
d10768f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Cabal card to the Global Collect gateway (also known as the
Ingenico gateway).
The Ingenico gateway docs do not include a test card number for Cabal,
and sending card numbers that follow the Luhn algorithm and fall within
the Cabal card range results in error messages of "Rejected".
Therefore, no additional remote or unit tests were added to the Global
Collect gateway to test the implementation of the Cabal card type.
CE-94 / CE-97
Unit:
20 tests, 88 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
Remote:
17 tests, 40 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed