Barclaycard Smartpay: Add support for shopper_statement gateway-specific field #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonxp
force-pushed
the
ce-105-barclaycard-smartpay-shopper-statement-gsf
branch
from
149935a to
e332bc9
Compare
jasonxp
changed the title
jasonxp
commented
Aug 30, 2019
| assert_match(/shopperInteraction=ContAuth/, data) | ||
| assert_match(/deviceFingerprint=abcde123/, data) | ||
| assert_match(/shopperInteraction=#{shopper_interaction}/, data) | ||
| assert_match(/shopperStatement=#{Regexp.quote(CGI.escape(shopper_statement))}/, data) |
There was a problem hiding this comment.
We escape all strings sent to the gateway here: https://github.com/activemerchant/active_merchant/blob/master/lib/active_merchant/billing/gateways/barclaycard_smartpay.rb#L229.
jasonxp
force-pushed
the
ce-105-barclaycard-smartpay-shopper-statement-gsf
branch
from
e332bc9 to
bef94fe
Compare
…fic field Unit: 4237 tests, 70448 assertions, 0 failures, 0 errors, 0 pendings, 2 omissions, 0 notifications 100% passed Remote: 35 tests, 75 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.2857% passed Unrelated pre-existing remote test failures: - test_successful_authorize_with_3ds2_browser_client_data (IdentifyShopper expected, RedirectShopper returned) - test_successful_third_party_payout (invalid credentials) CE-105
jasonxp
force-pushed
the
ce-105-barclaycard-smartpay-shopper-statement-gsf
branch
from
bef94fe to
e086fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.