Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe Payment Intents, Checkout V2: MOTO flag #3323

Merged

Conversation

britth
Copy link
Contributor

@britth britth commented Sep 3, 2019

This PR enables marking a transaction as MOTO on the Stripe Payment
Intents and Checkout V2 gateways. Note: For Stripe, accounts must
be configured to allow setting the MOTO flag. This PR also adds the list of
supported countries for Stripe Payment Intents.

Stripe Payment Intents
Remote:
28 tests, 115 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit:
6 tests, 42 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Checkout V2
Remote:
30 tests, 72 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit:
26 tests, 116 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@britth britth requested review from jeremywrowe, nfarve and a team September 3, 2019 15:00
Copy link

@nfarve nfarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Contributor

@jeremywrowe jeremywrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

This PR enables marking a transaction as MOTO on the Stripe Payment
Intents and Checkout V2 gateways. Note: For Stripe, accounts must
be configured to allow setting the MOTO flag (https://stripe.com/guides/strong-customer-authentication#phone-sales).
This PR also adds the list of supported countries for Stripe.

Stripe Payment Intents -
Remote:
28 tests, 115 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit:
6 tests, 42 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Checkout V2 -
Remote:
30 tests, 72 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit:
26 tests, 116 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@britth britth force-pushed the stripe-pi-checkout-v2-moto-flag branch from ee94a2d to e3f59c1 Compare September 4, 2019 15:31
@britth britth merged commit e3f59c1 into activemerchant:master Sep 4, 2019
@britth britth deleted the stripe-pi-checkout-v2-moto-flag branch October 29, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants