Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlueSnap: Add Cabal card #3326

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Conversation

leila-alderman
Copy link
Contributor

Adds the Cabal card type to the BlueSnap gateway.

I have been able to successfully add a remote test for a failed purchase
transaction made with an invalid Cabal card; however, when I try to run
a remote test for a successful purchase with a Cabal card, I receive the
error message "Transaction failed because there are no available
processors." (error code 14016). According to the BlueSnap documentation,
resolving this error requires contacting BlueSnap Support.

BlueSnap provides a Cabal test card number
in their docs, so it seems that Cabal needs to enabled on our test
gateway in order to test Cabal on this gateway.

CE-94 / CE-103

Unit:
27 tests, 110 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Remote:
36 tests, 112 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

@leila-alderman leila-alderman requested review from a team September 3, 2019 16:58
Copy link
Contributor

@jasonxp jasonxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit:

@@ -139,6 +141,13 @@ def test_failed_purchase
assert_equal '14002', response.error_code
end

def test_failed_purchase_with_invalid_cabal_card
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test the success case for the cabal card type? I saw we added @cabal_credit_card but didn't find it used anywhere in our remote test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind on that. Re-read your PR description and see you did try to do that. 🤦‍♂

Copy link
Contributor

@bayprogrammer bayprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Adds the Cabal card type to the BlueSnap gateway.

I have been able to successfully add a remote test for a failed purchase
transaction made with an invalid Cabal card; however, when I try to run
a remote test for a successful purchase with a Cabal card, I receive the
error message "Transaction failed because there are no available
processors." (error code 14016). According to the [BlueSnap documentation](https://developers.bluesnap.com/v8976-JSON/docs/card-transaction-errors),
resolving this error requires contacting BlueSnap Support.

BlueSnap provides a [Cabal test card number](https://developers.bluesnap.com/docs/test-credit-cards)
in their docs, so it seems that Cabal needs to enabled on our test
gateway in order to test Cabal on this gateway.

CE-94 / CE-103

Unit:
27 tests, 110 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Remote:
36 tests, 112 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
@leila-alderman leila-alderman force-pushed the CE-103_bluesnap_add_cabal branch from 29d804f to c1c3fa4 Compare September 4, 2019 20:07
@leila-alderman leila-alderman deleted the CE-103_bluesnap_add_cabal branch September 4, 2019 20:08
@leila-alderman leila-alderman merged commit c1c3fa4 into master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants