Adyen: Set 3DS exemptions via API #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -340,6 +340,10 @@ def add_3ds(post, options) | |||
| post[:browserInfo] = { userAgent: options[:user_agent], acceptHeader: options[:accept_header] } | |||
| post[:additionalData] = { executeThreeD: 'true' } if options[:execute_threed] | |||
| end | |||
| if options[:sca_exemption] && !options[:execute_threed].nil? | |||
There was a problem hiding this comment.
This logic has some subtleties that might be worth locking down in the unit test suite. Could we add a couple tests which assert the expected shape of the outgoing request via a check_request block (a la test_update_shopper_statement_and_industry_usage_sent) given various combinations of :sca_exemption and :execute_threed options?
There was a problem hiding this comment.
This can be simplified by using Hash#has_key? eg:
if options.has_key?(:sca_exception) && options.has_key?(:execute_threed)
...
endThere was a problem hiding this comment.
Good call 👍 Since from what i've seen, these exemptions are only relevant for 3ds2, moved this snippet of logic up to the conditional related to 3ds2 and added unit tests to check that values are sent as expected
britth
force-pushed
the
adyen-set-3ds-exemptions-via-api
branch
2 times, most recently
from
9df0c8b to
c894331
Compare
There are a few different ways to request exemptions via Adyen. Users can let Adyen handle compliance by default, they can configure specific rules using dynamic 3dsecure, or they can set exemption flags via the API. This PR updates the Adyen gateway to allow users to set specific exemptions using the sca_exemption field, used in conjunction with the execute_threed field. Users can also now set execute_threed to false if they want to bypass 3DS on a transaction. Remote: 66 tests, 213 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.9697% passed (2 failures unrelated, related to standalone 3ds feature) Unit: 47 tests, 228 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
britth
force-pushed
the
adyen-set-3ds-exemptions-via-api
branch
from
c894331 to
fca5cad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few different ways to request exemptions via Adyen.
Users can let Adyen handle compliance by default, they can
configure specific rules using dynamic 3dsecure, or they can set
exemption flags via the API. This PR updates the Adyen gateway to
allow users to set specific exemptions using the sca_exemption
field, used in conjunction with the execute_threed field. Users
can also now set execute_threed to false if they want to bypass
3DS on a transaction.
Remote:
64 tests, 207 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
39 tests, 188 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed