Redsys: 3ds support #3336
Merged
Redsys: 3ds support #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britth
force-pushed
the
ents-14-redsys-3ds-support
branch
2 times, most recently
from
ddb6305 to
985e95f
Compare
nfarve
reviewed
Sep 11, 2019
| data[:order_id].to_s + | ||
| @options[:login].to_s + | ||
| data[:currency] | ||
| data[:order_id].to_s + |
There was a problem hiding this comment.
I added it after getting a rubocop error, i'll double check 👍
britth
force-pushed
the
ents-14-redsys-3ds-support
branch
from
985e95f to
26e5261
Compare
This PR preps Redsys for 3DS integration. It adds the test and production URLs for the 3DS service, updates the commit method to interact with the appropriate endpoint for 3DS transactions, and updates the parse method to appropriately parse responses. Unit: 34 tests, 104 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 20 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
britth
force-pushed
the
ents-14-redsys-3ds-support
branch
from
26e5261 to
74506fc
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3DS support to Redsys. It adds the test and production
URLs for the 3DS service, updates the commit method to interact with the
appropriate endpoint for 3DS transactions, and updates the parse method
to appropriately parse responses.
Unit:
34 tests, 104 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
20 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed