Adyen: Send "NA" instead of "N/A" #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an address field is not provided, the default will now be "NA" instead of the previous "N/A". According to Adyen, this should improve acceptance rates for transactions that do not include an address provided by the customer. CE-115 Unit: 47 tests, 228 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 66 tests, 213 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.9697% passed The two tests that are failing: - test_successful_purchase_with_auth_data_via_threeds1_standalone - test_successful_purchase_with_auth_data_via_threeds2_standalone These failures seem to be unrelated to the changes here.
leila-alderman
force-pushed
the
CE-115_adyen_send_na
branch
from
54b0532 to
df372a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an address field is not provided, the default will now be "NA"
instead of the previous "N/A". According to Adyen, this should improve
acceptance rates for transactions that do not include an address
provided by the customer.
CE-115
Unit:
47 tests, 228 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
Remote:
66 tests, 213 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
96.9697% passed
The two tests that are failing:
These failures seem to be unrelated to the changes here as these
tests are also failing on the
masterbranch.