Credorax: Add 3DS 2.0 #3342
Merged
Credorax: Add 3DS 2.0 #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britth
approved these changes
Sep 13, 2019
| @@ -270,13 +270,38 @@ def add_email(post, options) | |||
| def add_3d_secure(post, options) | |||
| if options[:eci] && options[:xid] | |||
| add_3d_secure_1_data(post, options) | |||
| elsif options[:execute_threed] | |||
| three_ds_2_options = options[:three_ds_2] | |||
| browser_info = three_ds_2_options[:browser_info] | |||
There was a problem hiding this comment.
should we check that there is a :three_ds_2 key in the options hash before proceeding in this part to prevent errors, maybe in the elsif add && options[:three_ds_2] or something similar
There was a problem hiding this comment.
Yeah shouldn't this be options[:three_d_secure] , and condition on version? https://github.com/activemerchant/active_merchant/wiki/Standardized-3DS-Fields
There was a problem hiding this comment.
@curiousepic We pass a different hash of values for 3DS direct.
There was a problem hiding this comment.
britth
reviewed
Sep 13, 2019
| three_ds_2_options = options[:three_ds_2] | ||
| browser_info = three_ds_2_options[:browser_info] | ||
| post[:'3ds_initiate'] = options[:three_ds_initiate] || '01' | ||
| post[:'3ds_purchasedate'] = Time.now.utc.strftime('%Y%m%d%I%M%S') |
There was a problem hiding this comment.
saw mention of something similar on another PR - not sure if there are any intricacies that need to be considered here in terms of Time.now v Time.current
There was a problem hiding this comment.
Actually since I am using utc I think want Time.now actually.
nfarve
force-pushed
the
credorax_3ds2
branch
from
852e2e1 to
ae369a8
Compare
Adds 3DS 2.0 fields to credorax and a new field that is required for passing 3DS authenticated fields. Loaded suite test/remote/gateways/remote_credorax_test .......................... ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 26 tests, 73 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Loaded suite test/unit/gateways/credorax_test ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 23 tests, 124 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
nfarve
force-pushed
the
credorax_3ds2
branch
from
ae369a8 to
c9a851c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 3DS 2.0 fields to credorax and a new field that is required for
passing 3DS authenticated fields.
Loaded suite test/remote/gateways/remote_credorax_test
..........................
26 tests, 73 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Loaded suite test/unit/gateways/credorax_test
23 tests, 124 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed