Mundipagg: Append errors to message response field #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonxp
force-pushed
the
ce-112-mundipagg-error-messages
branch
2 times, most recently
from
b933144 to
eb475ee
Compare
jasonxp
commented
Sep 16, 2019
| @@ -38,6 +38,8 @@ def setup | |||
| billing_address: address, | |||
| description: 'Store Purchase' | |||
| } | |||
|
|
|||
| @gateway_response_error = 'Esta loja n??o possui um meio de pagamento configurado para a bandeira VR' | |||
There was a problem hiding this comment.
I haven't been able to reproduce one of these errors, as they likely require a configuration discrepancy. There is thus no corresponding remote test. However, the code and test were written based on examination of a real such error encountered by a user.
jasonxp
force-pushed
the
ce-112-mundipagg-error-messages
branch
from
eb475ee to
438afc5
Compare
For purchase, authorize, and store, extract any error messages from the gateway response and append them to the "message" response feld. Mundipagg can return errors at either the top level of the response object, or under the last_transaction gateway_response key. CE-114 Unit: 4268 tests, 70604 assertions, 0 failures, 0 errors, 0 pendings, 2 omissions, 0 notifications 100% passed Remote: 37 tests, 93 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
jasonxp
force-pushed
the
ce-112-mundipagg-error-messages
branch
from
438afc5 to
b1e0807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
purchase,authorize, andstore, extract any error messages from the gateway response and append them to the "message" response feld. Mundipagg can return errors at either the top level of the response object, or under thelast_transactiongateway_responsekey.