Credorax: Add A Mandatory 3DS field #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Credorax sandbox seems to be having trouble. About 10 tests are failing on master. |
nfarve
force-pushed
the
credorax_extra_3ds_field
branch
from
812119e to
a2c1457
Compare
|
Remote tests working again! |
britth
approved these changes
Sep 20, 2019
| post[:d5] = browser_info[:user_agent] | ||
| post[:'3ds_transtype'] = '01' || options[:transaction_type] |
There was a problem hiding this comment.
should we set this as options[:transaction_type] || '01' so that if they actually pass in a value it'll use that over '01'
nfarve
force-pushed
the
credorax_extra_3ds_field
branch
from
a2c1457 to
65c7afe
Compare
Credorax now requires `3ds_transtype` is required. This passes a default value if none is passed. Also passes optional field `3ds_version`. Loaded suite test/unit/gateways/credorax_test Started ....................... 23 tests, 125 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Loaded suite test/remote/gateways/remote_credorax_test Started .......................... 26 tests, 74 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
nfarve
force-pushed
the
credorax_extra_3ds_field
branch
from
65c7afe to
0b2d699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credorax now requires
3ds_transtypeis required. This passes a defaultvalue if none is passed. Also passes optional field
3ds_version.Loaded suite test/unit/gateways/credorax_test
Started
.......................
Finished in 0.020239 seconds.
23 tests, 125 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed