Adyen: Add Cabal card #3361
Merged
Adyen: Add Cabal card #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therufs
reviewed
Sep 20, 2019
jasonxp
reviewed
Sep 20, 2019
jasonxp
reviewed
Sep 20, 2019
jasonxp
reviewed
Sep 20, 2019
jasonxp
reviewed
Sep 24, 2019
|
|
||
| initial_response = commit('authorise', post, options) | ||
|
|
||
| if initial_response.success? && card_not_stored?(initial_response) |
There was a problem hiding this comment.
👍Nice refactor. This is a lot easier to read/understand.
jasonxp
reviewed
Sep 24, 2019
jasonxp
reviewed
Sep 24, 2019
| @@ -33,6 +33,24 @@ def setup | |||
| :brand => 'elo' | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Just a heads up in case you didn't notice -- there appear to be conflicts in this file now.
There was a problem hiding this comment.
Yep, I'm aware, but I generally hold off on rebasing until I'm all set to go.
jasonxp
reviewed
Sep 25, 2019
jasonxp
reviewed
Sep 25, 2019
jasonxp
reviewed
Sep 25, 2019
| def test_failed_store_with_cabal_card | ||
| assert response = @gateway.store(@cabal_credit_card, @options) | ||
| assert_failure response | ||
| assert_equal 'Recurring transactions are not supported for this card type.', response.message |
|
Added a couple of minor recommendations, but looks good! |
jasonxp
reviewed
Sep 25, 2019
| end | ||
|
|
||
| def card_not_stored?(response) | ||
| response.authorization ? response.authorization.split('#')[2].nil? : true |
jasonxp
reviewed
Sep 25, 2019
| @@ -459,6 +466,23 @@ def add_browser_info(browser_info, post) | |||
| userAgent: browser_info[:user_agent] | |||
| } | |||
| end | |||
|
|
|||
| def unsupported_failure_response(initial_response) | |||
leila-alderman
force-pushed
the
CE-99_adyen_add_cabal
branch
from
c73e733 to
b566590
Compare
Added the Cabal card to the Adyen gateway, including adding unit and remote tests. Currently, Adyen does not support recurring transactions for Cabal cards, so additional logic was added to the `store` method to return an error message when attempting to store a Cabal card. Since the `store` method for Adyen uses the `authorise` action, even though Cabal cards cannot be successfully stored, the response from the gateway is successful and does not return any sort of error message. Therefore, the response from the gateway is altered to accurately reflect when a card is not successfully stored by Adyen. CE-99 Unit: 40 tests, 193 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 72 tests, 232 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 95.8333% passed The two failing tests are - `test_successful_purchase_with_auth_data_via_threeds1_standalone` - `test_successful_purchase_with_auth_data_via_threeds2_standalone` These two tests were recently added in #3294 and appear to have never passed for Spreedly.
leila-alderman
force-pushed
the
CE-99_adyen_add_cabal
branch
from
b566590 to
f387a0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Cabal card to the Adyen gateway, including adding unit and
remote tests.
Currently, Adyen does not support recurring transactions for Cabal
cards, so additional logic was added to the
storemethod to return anerror message when attempting to store a Cabal card. Since the
storemethod for Adyen uses the
authoriseaction, even though Cabal cardscannot be successfully stored, the response from the gateway is
successful and does not return any sort of error message.
CE-99
Unit:
40 tests, 193 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
Remote:
68 tests, 214 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed