SafeCharge: Change Verify to send 0 amount #4332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates tests to reflect new `verify` flow. CE-190 Rubocop: 728 files inspected, no offenses detected Unit: 5068 tests, 75098 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: Loaded suite test/remote/gateways/remote_safe_charge_test 30 tests, 83 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
dsmcclain
commented
Feb 22, 2022
| assert !response.params['acsurl'].blank? | ||
| assert !response.params['pareq'].blank? | ||
| assert !response.params['xid'].blank? | ||
| assert_equal 'Attempted But Card Not Enrolled', response.params['threedreason'] |
There was a problem hiding this comment.
This fix is for a failing remote test unrelated to the verify changes.
This test covers a case where a 3ds transaction returns a Payer Response (pa_res) indicating that the 3ds flow has been rejected.
Quoted from Nuvei/SafeCharge's Gateway Direct API Integration Guide:
If the customer's card is not enrolled in 3D Secure, SafeCharge returns the regular Gateway parameters...and in addition the parameters ECI and ThreeDReason.
Based on this, the acsurl, pareq, and xid fields should not have a value for this particular response.
therufs
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates tests to reflect new
verifyflow.CE-190
Rubocop:
728 files inspected, no offenses detected
Unit:
5068 tests, 75098 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
Loaded suite test/remote/gateways/remote_safe_charge_test
30 tests, 83 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed