Shift4: Add store method & bug fixes
#4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajawadmirza
force-pushed
the
SER-158_add_store
branch
from
1609a85 to
5dce3ec
Compare
dsmcclain
suggested changes
Jun 27, 2022
ajawadmirza
force-pushed
the
SER-158_add_store
branch
from
5dce3ec to
9a86772
Compare
Added `store` implementation along with test cases and fixed amount to pass value in cents. Also added `present` field in card. SER-158 SER-164 SER-165 Unit: 5233 tests, 76009 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 746 files inspected, no offenses detected Remote: 16 tests, 35 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
ajawadmirza
force-pushed
the
SER-158_add_store
branch
from
9a86772 to
80aa2b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
storeimplementation along with test cases and fixed amount to pass value in cents. Also addedpresentfield in card.SER-158
SER-164
SER-165
Unit:
5233 tests, 76009 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Rubocop:
746 files inspected, no offenses detected
Remote:
16 tests, 35 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed