Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credorax: Update OpCode for Credit transactions #4526

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

rachelkirk
Copy link
Contributor

Credit should now be using O=35 instead of O=6

CE-2235

Unit:
80 tests, 381 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
46 tests, 157 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
86.9565% passed
*6 test failures have been failing since April

Local:
5273 tests, 76175 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@rachelkirk rachelkirk requested a review from a team August 8, 2022 15:28
Copy link
Contributor

@jcreiff jcreiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (again...)

Test results were the same for me as well.

Credit should now be using `O=35` instead of `O=6`

CE-2235

Unit:
80 tests, 381 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
46 tests, 157 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
86.9565% passed
*6 test failures have been failing since April

Local:
5273 tests, 76175 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@rachelkirk rachelkirk force-pushed the CER-64_credorax_op_code branch from 11f016c to 4954046 Compare August 8, 2022 19:18
@rachelkirk rachelkirk merged commit 4954046 into master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants