Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airwallex: Add skip_3ds field #4534

Merged

Conversation

ajawadmirza
Copy link
Contributor

Added skip_3ds field support for airwallex along with unit and remote test cases.

SEr-229

Unit:
5276 tests, 76200 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Rubocop:
746 files inspected, no offenses detected

Remote:
27 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@ajawadmirza ajawadmirza force-pushed the SER-229_add_gsf_airwallex branch from a68f13b to 19ea8b1 Compare August 15, 2022 08:39
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be good to ship after we simplify the conditional.

lib/active_merchant/billing/gateways/airwallex.rb Outdated Show resolved Hide resolved
@ajawadmirza ajawadmirza force-pushed the SER-229_add_gsf_airwallex branch from 19ea8b1 to c03048d Compare August 16, 2022 06:31
Added `skip_3ds` field support for airwallex along with unit and remote test cases.

SEr-229

Unit:
5276 tests, 76200 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Rubocop:
746 files inspected, no offenses detected

Remote:
27 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@ajawadmirza ajawadmirza force-pushed the SER-229_add_gsf_airwallex branch from c03048d to d157c8d Compare August 16, 2022 06:35
@ajawadmirza ajawadmirza requested a review from naashton August 16, 2022 06:36
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@naashton naashton merged commit cfb48c3 into activemerchant:master Aug 16, 2022
Sainterman pushed a commit to Sainterman/active_merchant that referenced this pull request Aug 18, 2022
Added `skip_3ds` field support for airwallex along with unit and remote test cases.

SEr-229

Unit:
5276 tests, 76200 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Rubocop:
746 files inspected, no offenses detected

Remote:
27 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants