Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbital: Fix CardSecValInd #4563

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

molbrown
Copy link
Contributor

@molbrown molbrown commented Sep 2, 2022

The card sec val ind is only valid on BIN 1 merchant Visa and Discover transactions

This issue is not reflected in the sandbox, but was exposed in Developer
Center testing during certification. The intended application of this
field is also documented in the code comment.

ECS-2144

Unit:
141 tests, 803 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
119 tests, 497 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@molbrown molbrown requested a review from a team September 2, 2022 18:27
Copy link
Contributor

@aenand aenand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@molbrown molbrown marked this pull request as draft September 7, 2022 16:07
@molbrown molbrown force-pushed the orbital_CardSecValInd branch from aadc3b5 to 04d3fe0 Compare September 9, 2022 18:01
@molbrown molbrown marked this pull request as ready for review September 9, 2022 18:01
The card sec val ind is only valid on BIN 1 merchant Visa and Discover transactions

This issue is not reflected in the sandbox, but was exposed in Developer
Center testing during certification. The intended application of this
field is also documented in the code comment.

ECS-2144

Unit:
141 tests, 806 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
119 tests, 497 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@molbrown molbrown force-pushed the orbital_CardSecValInd branch from 04d3fe0 to 18cd670 Compare September 12, 2022 20:30
@molbrown molbrown merged commit 18cd670 into activemerchant:master Sep 12, 2022
@molbrown molbrown deleted the orbital_CardSecValInd branch September 12, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants