CyberSource: add support for several fields #4595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreiff
approved these changes
Sep 28, 2022
This PR adds support for `discount_management_indicator` and `purchase_tax_amount` in the `purchaseTotals` element, and `installment_total_amount` and `installment_annual_interest_rate` in the installment element. It also updates to the most current version of the CyberSource API XSD file. CER-194 Unit Tests: 120 tests, 577 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Tests: 117 tests, 598 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.4359% passed *The three failing tests are also failing on master and relate to 3DS, require extra action to pass. Local Tests: 5353 tests, 76623 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
rachelkirk
force-pushed
the
CER-194_cybersource_add_fields
branch
from
c1eddef to
8777364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
discount_management_indicatorandpurchase_tax_amountin thepurchaseTotalselement, andinstallment_total_amountandinstallment_annual_interest_ratein the installment element.It also updates to the most current version of the CyberSource API XSD file.
CER-194
Unit Tests:
120 tests, 577 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote Tests:
117 tests, 598 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.4359% passed
*The three failing tests are also failing on master and relate to 3DS, require extra action to pass.
Local Tests:
5353 tests, 76623 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed