IPG Gateway: override store id #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naashton
approved these changes
Nov 2, 2022
| @credentials[:store_id] = options[:store_id] if options[:store_id].present? | ||
| end | ||
|
|
||
| def commit(action, request, options = {}) |
There was a problem hiding this comment.
Thank you for making the options param optional and cleaning up the other method calls
ECS-2655 The IPG gateway requires a `store_id` to be used as part of the authentication. This value is correlates to a given merchant and is currently saved on the gateway initalize. By saving it only then, it prevents merchants with submerchants from using this gateway. This commit adds a new optional field that will override the saved `store_id` with one passed in for that merchant. Test Summary Remote: 18 tests, 54 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
aenand
force-pushed
the
ipg_gateway_override_store_id
branch
from
57b984d to
ab92469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECS-2655
The IPG gateway requires a
store_idto beused as part of the authentication. This
value is correlates to a given merchant and
is currently saved on the gateway initalize.
By saving it only then, it prevents merchants
with submerchants from using this gateway.
This commit adds a new optional field that
will override the saved
store_idwith onepassed in for that merchant.
Test Summary
Remote:
18 tests, 54 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed