Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payeezy Scrub Cryptogram #4633

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
* Orbital: integration improvements [molbrown] #4626
* iVeri: add new url [almalee24] #4630
* Payeezy: Enable Apple Pay support [naashton] #4631
* Payeezy: Scrub Cryptogram [naashton] #4633

== Version 1.127.0 (September 20th, 2022)
* BraintreeBlue: Add venmo profile_id [molbrown] #4512
Expand Down
5 changes: 4 additions & 1 deletion lib/active_merchant/billing/gateways/payeezy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,17 @@ def scrub(transcript)
gsub(%r((Apikey: )(\w|-)+), '\1[FILTERED]').
gsub(%r((\\?"card_number\\?":\\?")\d+), '\1[FILTERED]').
gsub(%r((\\?"cvv\\?":\\?")\d+), '\1[FILTERED]').
gsub(%r((\\?"cvv\\?":\\?)\d+), '\1[FILTERED]').
gsub(%r((\\?"account_number\\?":\\?")\d+), '\1[FILTERED]').
gsub(%r((\\?"routing_number\\?":\\?")\d+), '\1[FILTERED]').
gsub(%r((\\?card_number=)\d+(&?)), '\1[FILTERED]').
gsub(%r((\\?cvv=)\d+(&?)), '\1[FILTERED]').
gsub(%r((\\?apikey=)\w+(&?)), '\1[FILTERED]').
gsub(%r{(\\?"credit_card\.card_number\\?":)(\\?"[^"]+\\?")}, '\1[FILTERED]').
gsub(%r{(\\?"credit_card\.cvv\\?":)(\\?"[^"]+\\?")}, '\1[FILTERED]').
gsub(%r{(\\?"apikey\\?":)(\\?"[^"]+\\?")}, '\1[FILTERED]')
gsub(%r{(\\?"apikey\\?":)(\\?"[^"]+\\?")}, '\1[FILTERED]').
gsub(%r{(\\?"cavv\\?":)(\\?"[^"]+\\?")}, '\1[FILTERED]').
gsub(%r{(\\?"xid\\?":)(\\?"[^"]+\\?")}, '\1[FILTERED]')
end

private
Expand Down
10 changes: 10 additions & 0 deletions test/remote/gateways/remote_payeezy_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -408,4 +408,14 @@ def test_transcript_scrubbing_echeck
assert_scrubbed(@check.routing_number, transcript)
assert_scrubbed(@gateway.options[:token], transcript)
end

def test_transcript_scrubbing_network_token
transcript = capture_transcript(@gateway) do
@gateway.purchase(@amount, @apple_pay_card, @options)
end
transcript = @gateway.scrub(transcript)

assert_scrubbed(@apple_pay_card.payment_cryptogram, transcript)
assert_scrubbed(@apple_pay_card.verification_value, transcript)
end
end
92 changes: 92 additions & 0 deletions test/unit/gateways/payeezy_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,10 @@ def test_scrub_echeck
assert_equal @gateway.scrub(pre_scrubbed_echeck), post_scrubbed_echeck
end

def test_scrub_network_token
assert_equal @gateway.scrub(pre_scrubbed_network_token), post_scrubbed_network_token
end

private

def pre_scrubbed
Expand Down Expand Up @@ -608,6 +612,94 @@ def post_scrubbed_store
TRANSCRIPT
end

def pre_scrubbed_network_token
<<~TRANSCRIPT
opening connection to api-cert.payeezy.com:443...
opened
starting SSL for api-cert.payeezy.com:443...
SSL established
<- "POST /v1/transactions HTTP/1.1\r\nContent-Type: application/json\r\nApikey: oKB61AAxbN3xwC6gVAH3dp58FmioHSAT\r\nToken: fdoa-a480ce8951daa73262734cf102641994c1e55e7cdf4c02b6\r\nNonce: 2713241561.4909368\r\nTimestamp: 1668784714406\r\nAuthorization: NDU2ZWRiNmUwMmUxNGMwOGIwYjMxYTAxMDkzZDcwNWNhM2Y0ODExNmRmMTNjNDVjMTFhODMyNTg4NDdiNzZiNw==\r\nConnection: close\r\nAccept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3\r\nAccept: */*\r\nUser-Agent: Ruby\r\nHost: api-cert.payeezy.com\r\nContent-Length: 462\r\n\r\n"
<- "{\"transaction_type\":\"purchase\",\"merchant_ref\":null,\"3DS\":{\"type\":\"D\",\"cardholder_name\":\"Longbob\",\"card_number\":\"4761209980011439\",\"exp_date\":\"1122\",\"cvv\":569,\"xid\":\"YwAAAAAABaYcCMX/OhNRQAAAAAA=\",\"cavv\":\"YwAAAAAABaYcCMX/OhNRQAAAAAA=\",\"wallet_provider_id\":\"APPLE_PAY\"},\"method\":\"3DS\",\"eci_indicator\":5,\"billing_address\":{\"street\":\"456 My Street\",\"city\":\"Ottawa\",\"state_province\":\"ON\",\"zip_postal_code\":\"K1C2N6\",\"country\":\"CA\"},\"currency_code\":\"USD\",\"amount\":\"100\"}"
-> "HTTP/1.1 201 Created\r\n"
-> "Date: Fri, 18 Nov 2022 15:18:35 GMT\r\n"
-> "Content-Type: application/json;charset=UTF-8\r\n"
-> "Connection: close\r\n"
-> "X-Backside-Transport: OK OK,OK OK\r\n"
-> "Content-Language: en-US\r\n"
-> "X-Global-Transaction-ID: 7f41427d6377a24aa50b34df\r\n"
-> "Strict-Transport-Security: max-age=31536000; includeSubDomains\r\n"
-> "X-Xss-Protection: 1; mode=block\r\n"
-> "Cache-Control: no-store, no-cache, must-revalidate\r\n"
-> "Pragma: no-cache\r\n"
-> "X-Frame-Options: SAMEORIGIN\r\n"
-> "Referrer-Policy: strict-origin\r\n"
-> "Feature-Policy: vibrate 'self'\r\n"
-> "Content-Security-Policy: default-src 'none'; frame-ancestors 'self'; script-src 'unsafe-inline' 'self' *.googleapis.com *.klarna.com *.masterpass.com *.mastercard.com *.newrelic.com *.npci.org.in *.nr-data.net *.google-analytics.com *.google.com *.getsitecontrol.com *.gstatic.com *.kxcdn.com 'strict-dynamic' 'nonce-6f62fa22a79de4c553d2bbde' 'unsafe-eval' 'unsafe-inline'; connect-src 'self'; img-src 'self'; style-src 'self'; base-uri 'self';\r\n"
-> "Access-Control-Allow-Origin: http://localhost:8080\r\n"
-> "Access-Control-Request-Headers: origin, x-requested-with, accept, content-type\r\n"
-> "Access-Control-Max-Age: 3628800\r\n"
-> "Access-Control-Allow-Methods: GET, PUT, POST, DELETE\r\n"
-> "Access-Control-Allow-Headers: Content-Type, apikey, token\r\n"
-> "Via: 1.1 dca1-bit16021\r\n"
-> "Transfer-Encoding: chunked\r\n"
-> "\r\n"
-> "249\r\n"
reading 585 bytes...
-> "{\"correlation_id\":\"134.6878471461658\",\"transaction_status\":\"approved\",\"validation_status\":\"success\",\"transaction_type\":\"purchase\",\"transaction_id\":\"ET188163\",\"transaction_tag\":\"10032826722\",\"method\":\"3ds\",\"amount\":\"100\",\"currency\":\"USD\",\"avs\":\"4\",\"cvv2\":\"U\",\"token\":{\"token_type\":\"FDToken\",\"token_data\":{\"value\":\"9324008290401439\"}},\"card\":{\"type\":\"VISA\",\"cardholder_name\":\"Longbob\",\"card_number\":\"1439\",\"exp_date\":\"1122\"},\"bank_resp_code\":\"100\",\"bank_message\":\"Approved\",\"gateway_resp_code\":\"00\",\"gateway_message\":\"Transaction Normal\",\"eCommerce_flag\":\"5\",\"retrieval_ref_no\":\"221118\"}"
read 585 bytes
reading 2 bytes...
-> "\r\n"
read 2 bytes
-> "0\r\n"
-> "\r\n"
Conn close
TRANSCRIPT
end

def post_scrubbed_network_token
<<~TRANSCRIPT
opening connection to api-cert.payeezy.com:443...
opened
starting SSL for api-cert.payeezy.com:443...
SSL established
<- "POST /v1/transactions HTTP/1.1\r\nContent-Type: application/json\r\nApikey: [FILTERED]\r\nToken: [FILTERED]\r\nNonce: 2713241561.4909368\r\nTimestamp: 1668784714406\r\nAuthorization: NDU2ZWRiNmUwMmUxNGMwOGIwYjMxYTAxMDkzZDcwNWNhM2Y0ODExNmRmMTNjNDVjMTFhODMyNTg4NDdiNzZiNw==\r\nConnection: close\r\nAccept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3\r\nAccept: */*\r\nUser-Agent: Ruby\r\nHost: api-cert.payeezy.com\r\nContent-Length: 462\r\n\r\n"
<- "{\"transaction_type\":\"purchase\",\"merchant_ref\":null,\"3DS\":{\"type\":\"D\",\"cardholder_name\":\"Longbob\",\"card_number\":\"[FILTERED]\",\"exp_date\":\"1122\",\"cvv\":[FILTERED],\"xid\":[FILTERED],\"cavv\":[FILTERED],\"wallet_provider_id\":\"APPLE_PAY\"},\"method\":\"3DS\",\"eci_indicator\":5,\"billing_address\":{\"street\":\"456 My Street\",\"city\":\"Ottawa\",\"state_province\":\"ON\",\"zip_postal_code\":\"K1C2N6\",\"country\":\"CA\"},\"currency_code\":\"USD\",\"amount\":\"100\"}"
-> "HTTP/1.1 201 Created\r\n"
-> "Date: Fri, 18 Nov 2022 15:18:35 GMT\r\n"
-> "Content-Type: application/json;charset=UTF-8\r\n"
-> "Connection: close\r\n"
-> "X-Backside-Transport: OK OK,OK OK\r\n"
-> "Content-Language: en-US\r\n"
-> "X-Global-Transaction-ID: 7f41427d6377a24aa50b34df\r\n"
-> "Strict-Transport-Security: max-age=31536000; includeSubDomains\r\n"
-> "X-Xss-Protection: 1; mode=block\r\n"
-> "Cache-Control: no-store, no-cache, must-revalidate\r\n"
-> "Pragma: no-cache\r\n"
-> "X-Frame-Options: SAMEORIGIN\r\n"
-> "Referrer-Policy: strict-origin\r\n"
-> "Feature-Policy: vibrate 'self'\r\n"
-> "Content-Security-Policy: default-src 'none'; frame-ancestors 'self'; script-src 'unsafe-inline' 'self' *.googleapis.com *.klarna.com *.masterpass.com *.mastercard.com *.newrelic.com *.npci.org.in *.nr-data.net *.google-analytics.com *.google.com *.getsitecontrol.com *.gstatic.com *.kxcdn.com 'strict-dynamic' 'nonce-6f62fa22a79de4c553d2bbde' 'unsafe-eval' 'unsafe-inline'; connect-src 'self'; img-src 'self'; style-src 'self'; base-uri 'self';\r\n"
-> "Access-Control-Allow-Origin: http://localhost:8080\r\n"
-> "Access-Control-Request-Headers: origin, x-requested-with, accept, content-type\r\n"
-> "Access-Control-Max-Age: 3628800\r\n"
-> "Access-Control-Allow-Methods: GET, PUT, POST, DELETE\r\n"
-> "Access-Control-Allow-Headers: Content-Type, apikey, token\r\n"
-> "Via: 1.1 dca1-bit16021\r\n"
-> "Transfer-Encoding: chunked\r\n"
-> "\r\n"
-> "249\r\n"
reading 585 bytes...
-> "{\"correlation_id\":\"134.6878471461658\",\"transaction_status\":\"approved\",\"validation_status\":\"success\",\"transaction_type\":\"purchase\",\"transaction_id\":\"ET188163\",\"transaction_tag\":\"10032826722\",\"method\":\"3ds\",\"amount\":\"100\",\"currency\":\"USD\",\"avs\":\"4\",\"cvv2\":\"U\",\"token\":{\"token_type\":\"FDToken\",\"token_data\":{\"value\":\"9324008290401439\"}},\"card\":{\"type\":\"VISA\",\"cardholder_name\":\"Longbob\",\"card_number\":\"[FILTERED]\",\"exp_date\":\"1122\"},\"bank_resp_code\":\"100\",\"bank_message\":\"Approved\",\"gateway_resp_code\":\"00\",\"gateway_message\":\"Transaction Normal\",\"eCommerce_flag\":\"5\",\"retrieval_ref_no\":\"221118\"}"
read 585 bytes
reading 2 bytes...
-> "\r\n"
read 2 bytes
-> "0\r\n"
-> "\r\n"
Conn close
TRANSCRIPT
end

def successful_purchase_response
<<~RESPONSE
{\"method\":\"credit_card\",\"amount\":\"1\",\"currency\":\"USD\",\"avs\":\"4\",\"card\":{\"type\":\"Visa\",\"cardholder_name\":\"Bobsen 995\",\"card_number\":\"4242\",\"exp_date\":\"0816\"},\"token\":{\"token_type\":\"transarmor\",\"token_data\":{\"value\":\"0152552999534242\"}},\"transaction_status\":\"approved\",\"validation_status\":\"success\",\"transaction_type\":\"purchase\",\"transaction_id\":\"ET114541\",\"transaction_tag\":\"55083431\",\"bank_resp_code\":\"100\",\"bank_message\":\"Approved\",\"gateway_resp_code\":\"00\",\"gateway_message\":\"Transaction Normal\",\"correlation_id\":\"124.1433862672836\"}
Expand Down