Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rapyd: Add customer object and fix tests #4838

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Rapyd: Add customer object and fix tests #4838

merged 1 commit into from
Aug 4, 2023

Conversation

aenand
Copy link
Contributor

@aenand aenand commented Jul 21, 2023

The Rapyd gateway requires the Customer object on multiple payment types now and is optional on all. This commit adds teh customer subhash to requests and updates the remote tests to pass

Remote:
32 tests, 76 assertions, 7 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 78.125% passed

@aenand aenand force-pushed the fix_rapyd_tests branch from 059c0fa to 3db9f4e Compare July 31, 2023 16:11
@aenand aenand marked this pull request as ready for review July 31, 2023 16:11
@aenand aenand requested a review from a team July 31, 2023 16:11
BritneyS
BritneyS requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@BritneyS BritneyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just had some concerns about field state and some code repetition

lib/active_merchant/billing/gateways/rapyd.rb Show resolved Hide resolved
lib/active_merchant/billing/gateways/rapyd.rb Outdated Show resolved Hide resolved
@aenand aenand requested a review from BritneyS August 1, 2023 19:32
BritneyS
BritneyS reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@BritneyS BritneyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, since it calls out the different use-cases directly, all in one place. I would just reconsider the naming with these changes.

lib/active_merchant/billing/gateways/rapyd.rb Outdated Show resolved Hide resolved
BritneyS
BritneyS approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@BritneyS BritneyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor looks good 🎉 Just take care of the pry line before merging.

test/unit/gateways/rapyd_test.rb Outdated Show resolved Hide resolved
@aenand
Rapyd: Add customer object and fix tests
9a94d0e 
The Rapyd gateway requires the Customer object on multiple payment
types now and is optional on all. This commit adds the customer subhash
to requests and updates the remote tests to pass since Rapyd has changed
it's requirements.

Remote:
31 tests, 88 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@aenand aenand merged commit bb37917 into master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BritneyS BritneyS BritneyS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aenand @BritneyS