Rapyd: add force_3ds_secure flag #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ------------------------------ Introduces a change for 3ds transactions when dealing with 3DS gateway specific besides the standard fields a GSF needs to be sent in order to force the 3DS flow, this change is needed because the '3d_require' attribute works as force flag not like feature flag. [SER-889](https://spreedly.atlassian.net/browse/SER-889) Remote Test: ------------------------------ Finished in 115.583277 seconds. 42 tests, 118 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.619% passed *Note*: The failure test, fails becase is reference transaction related to a wallet. Unit Tests: ------------------------------ Finished in 42.100949 seconds. 5643 tests, 78206 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 773 files inspected, no offenses detected
naashton
force-pushed
the
SER-889_rapyd_add_force_3ds_flag
branch
from
bb50147 to
747b2f3
Compare
jherreraa
pushed a commit
that referenced
this pull request
Nov 3, 2023
Summary: ------------------------------ Introduces a change for 3ds transactions when dealing with 3DS gateway specific besides the standard fields a GSF needs to be sent in order to force the 3DS flow, this change is needed because the '3d_require' attribute works as force flag not like feature flag. [SER-889](https://spreedly.atlassian.net/browse/SER-889) Remote Test: ------------------------------ Finished in 115.583277 seconds. 42 tests, 118 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.619% passed *Note*: The failure test, fails becase is reference transaction related to a wallet. Unit Tests: ------------------------------ Finished in 42.100949 seconds. 5643 tests, 78206 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 773 files inspected, no offenses detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces a change for 3ds transactions when dealing with 3DS gateway specific besides the standard fields a GSF needs to be sent in order to force the 3DS flow, this change is needed because the '3d_require' attribute works as a force flag, not like a feature flag.
SER-889
Tests
Remote Test:
Finished in 115.583277 seconds.
42 tests, 118 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.619% passed
Note: The failure test, fails becase is reference transaction related to a wallet.
Unit Tests:
Finished in 42.100949 seconds.
5643 tests, 78206 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
RuboCop:
773 files inspected, no offenses detected