Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plexo: Add support to NetworkToken payments #5130

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

edgarv09
Copy link
Contributor

@edgarv09 edgarv09 commented May 21, 2024

Add support to NetworkToken payments
SER-1240

Test summary:
Local:
5910 tests, 79650 assertions, 0 failures, 17 errors, 0 pendings, 0 omissions, 0 notifications 99.7124% passed
Unit:
25 tests, 134 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote:
32 tests, 36 assertions, 21 failures, 3 errors, 0 pendings, 3 omissions, 0 notifications 17.2414% passed

@edgarv09 edgarv09 requested review from Heavyblade, javierpedrozaing, gasb150 and a team May 22, 2024 19:13
@edgarv09 edgarv09 marked this pull request as ready for review May 22, 2024 19:13
@Heavyblade
Copy link
Collaborator

@edgarv09 there is not mention of the jira ticket on the PR

Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the review @edgarv09, left some comments for your consideration

test/remote/gateways/remote_plexo_test.rb Outdated Show resolved Hide resolved
test/remote/gateways/remote_plexo_test.rb Outdated Show resolved Hide resolved
test/remote/gateways/remote_plexo_test.rb Outdated Show resolved Hide resolved
test/remote/gateways/remote_plexo_test.rb Outdated Show resolved Hide resolved
test/unit/gateways/plexo_test.rb Show resolved Hide resolved
lib/active_merchant/billing/gateways/plexo.rb Show resolved Hide resolved
SER-140

adding support to make purchase, authorize transaction using network tokens in plexo gateway

Test summary:
Local:
5910 tests, 79650 assertions, 0 failures, 17 errors, 0 pendings, 0 omissions, 0 notifications
99.7124% passed
Unit:
25 tests, 134 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
32 tests, 36 assertions, 21 failures, 3 errors, 0 pendings, 3 omissions, 0 notifications
17.2414% passed
@edgarv09 edgarv09 force-pushed the SER-1240_Enable_NT_for_plexo branch from 975cf57 to d49571e Compare June 6, 2024 19:42
@edgarv09 edgarv09 merged commit 5d1455e into master Jun 6, 2024
5 checks passed
@edgarv09 edgarv09 deleted the SER-1240_Enable_NT_for_plexo branch June 6, 2024 19:49
bryansquadup pushed a commit to givehub/active_merchant that referenced this pull request Aug 21, 2024
SER-140

add support to make purchase, authorize transactions using network tokens in the plexo gateway

Test summary:
Local:
5910 tests, 79650 assertions, 0 failures, 17 errors, 0 pendings, 0 omissions, 0 notifications
99.7124% passed
Unit:
25 tests, 134 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
32 tests, 36 assertions, 21 failures, 3 errors, 0 pendings, 3 omissions, 0 notifications
17.2414% passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants