Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qrcode #470

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Qrcode #470

merged 8 commits into from
Oct 18, 2023

Conversation

VinnyHS2
Copy link
Contributor

Contributor checklist


Description

This pull request is implementing the qrcode modal. It installs a new dependency (qrcode.vue).

Related issue

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit f9cb915
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/652f136f10a61a00088f21de
😎 Deploy Preview https://deploy-preview-470--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis self-requested a review October 17, 2023 18:24
@andrewtavis
Copy link
Member

Thanks @VinnyHS2! Stoked for this 😊

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 17, 2023
@andrewtavis
Copy link
Member

andrewtavis commented Oct 17, 2023

Just FYI @VinnyHS2, there are some good code snippets in scopewu/qrcode.vue#50 (comment) for the QR Code talking about adding in a download functionality 😉😊 I'll add this to the future issues :)

@andrewtavis
Copy link
Member

@VinnyHS2: are you also getting Vue is not defined when you run docker-compose up --build? Currently the landing page doesn't load properly in the Netlify preview, and this is also reflected locally. Any ideas? :)

@VinnyHS2
Copy link
Contributor Author

Maybe I know what is happening, I will check it out

@VinnyHS2
Copy link
Contributor Author

My bad, this was one of my atempts to make this thing work

@andrewtavis
Copy link
Member

andrewtavis commented Oct 18, 2023

It looks like it's working now, @VinnyHS2 :) I'll get to the review later today! There are some minor changes that I'll make, but as I said during the call this is exactly what we're looking for 😊

@@ -5,6 +5,7 @@ services:
build:
context: ./backend
container_name: django_backend
# restart: always
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna remove this line here @VinnyHS2 :) Feel free to have this in your local file and just send along the other files 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There'll definitely be some formatting changes that I'll send through, @VinnyHS2, but this is so great 😊 I'm gonna send along the edits now so that I can show this off to the team in the weekly meeting 🥳 We'll be talking about this at the dev sync on Saturday as well!

I'll explain the changes I send along and will also unblock the download issue when this is all done!

@andrewtavis andrewtavis merged commit 21bacfb into activist-org:main Oct 18, 2023
@VinnyHS2 VinnyHS2 deleted the qrcode branch October 18, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants