-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qrcode #470
Qrcode #470
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
Thanks @VinnyHS2! Stoked for this 😊 |
Just FYI @VinnyHS2, there are some good code snippets in scopewu/qrcode.vue#50 (comment) for the QR Code talking about adding in a download functionality 😉😊 I'll add this to the future issues :) |
@VinnyHS2: are you also getting |
Maybe I know what is happening, I will check it out |
My bad, this was one of my atempts to make this thing work |
It looks like it's working now, @VinnyHS2 :) I'll get to the review later today! There are some minor changes that I'll make, but as I said during the call this is exactly what we're looking for 😊 |
@@ -5,6 +5,7 @@ services: | |||
build: | |||
context: ./backend | |||
container_name: django_backend | |||
# restart: always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna remove this line here @VinnyHS2 :) Feel free to have this in your local file and just send along the other files 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There'll definitely be some formatting changes that I'll send through, @VinnyHS2, but this is so great 😊 I'm gonna send along the edits now so that I can show this off to the team in the weekly meeting 🥳 We'll be talking about this at the dev sync on Saturday as well!
I'll explain the changes I send along and will also unblock the download issue when this is all done!
Contributor checklist
Description
This pull request is implementing the qrcode modal. It installs a new dependency (qrcode.vue).
Related issue
ModalQRCode
component #353