Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: renderpass #1342

Merged
merged 4 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,7 @@ export class MeshRendererComponent extends Component {
}
}

// $prerender() {
// }

static sort_$render(renderPass: RenderPass): ComponentSID[] {
const primitiveUids = MeshRendererComponent.sort_$render_inner(renderPass);
return primitiveUids;
}

private static sort_$render_inner(renderPass: RenderPass) {
if (
TransformComponent.updateCount === renderPass._lastTransformComponentsUpdateCount &&
CameraControllerComponent.updateCount ===
Expand Down
17 changes: 0 additions & 17 deletions src/foundation/renderer/RenderPass.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,7 @@ export class RenderPass extends RnObject {
public toRenderTransparentPrimitives = true;

public toRenderEffekseerEffects = false;
public drawCount = 1;
public __renderTargetColorAttachments?: RenderBufferTargetEnum[];
private __preEachDrawFunc?: (drawCount: number) => void;
private __postEachRenderFunc?: () => void;
private static __tmp_Vector4_0 = MutableVector4.zero();

Expand Down Expand Up @@ -101,27 +99,12 @@ export class RenderPass extends RnObject {
renderPass.isOutputForVr = this.isOutputForVr;
renderPass.toRenderOpaquePrimitives = this.toRenderOpaquePrimitives;
renderPass.toRenderTransparentPrimitives = this.toRenderTransparentPrimitives;
renderPass.__preEachDrawFunc = this.__preEachDrawFunc;
renderPass.__postEachRenderFunc = this.__postEachRenderFunc;
renderPass.__renderTargetColorAttachments = this.__renderTargetColorAttachments?.concat();

return renderPass;
}

setPreDrawFunction(func: (drawCount: number) => void) {
this.__preEachDrawFunc = func;
}

unsetPreDrawFunction() {
this.__preEachDrawFunc = void 0;
}

doPreEachDraw(drawCount: number) {
if (this.__preEachDrawFunc != null) {
this.__preEachDrawFunc(drawCount);
}
}

setPostRenderFunction(func: () => void) {
this.__postEachRenderFunc = func;
}
Expand Down
2 changes: 1 addition & 1 deletion src/foundation/system/System.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export class System {
this.__cgApiResourceRepository.clearFrameBuffer(renderPass);
}

let skipNormalRender = false;
let skipNormalRender = renderPass.entities.length === 0 ? true : false;
if (this.processApproach === ProcessApproach.WebGPU) {
const webGpuStrategyBasic = WebGpuStrategyBasic.getInstance();
skipNormalRender = webGpuStrategyBasic.renderWithRenderBundle(renderPass);
Expand Down
40 changes: 16 additions & 24 deletions src/webgl/WebGLStrategyDataTexture.ts
Original file line number Diff line number Diff line change
Expand Up @@ -725,34 +725,26 @@ ${returnType} get_${methodName}(highp float _instanceId, const int idxOfArray) {
isVRMainPass
);

for (let j = 0; j < renderPass.drawCount; j++) {
renderPass.doPreEachDraw(j);

// For opaque primitives
if (renderPass.toRenderOpaquePrimitives) {
for (let i = 0; i <= renderPass._lastOpaqueIndex; i++) {
const primitiveUid = primitiveUids[i];
this.renderInner(primitiveUid, glw, renderPass, isVRMainPass, displayIdx);
}
// For opaque primitives
if (renderPass.toRenderOpaquePrimitives) {
for (let i = 0; i <= renderPass._lastOpaqueIndex; i++) {
const primitiveUid = primitiveUids[i];
this.renderInner(primitiveUid, glw, renderPass, isVRMainPass, displayIdx);
}
}

// For translucent primitives
if (renderPass.toRenderTransparentPrimitives) {
if (!MeshRendererComponent.isDepthMaskTrueForTransparencies) {
// disable depth write for transparent primitives
gl.depthMask(false);
}
// For translucent primitives
if (renderPass.toRenderTransparentPrimitives) {
if (!MeshRendererComponent.isDepthMaskTrueForTransparencies) {
// disable depth write for transparent primitives
gl.depthMask(false);
}

for (
let i = renderPass._lastOpaqueIndex + 1;
i <= renderPass._lastTransparentIndex;
i++
) {
const primitiveUid = primitiveUids[i];
this.renderInner(primitiveUid, glw, renderPass, isVRMainPass, displayIdx);
}
gl.depthMask(true);
for (let i = renderPass._lastOpaqueIndex + 1; i <= renderPass._lastTransparentIndex; i++) {
const primitiveUid = primitiveUids[i];
this.renderInner(primitiveUid, glw, renderPass, isVRMainPass, displayIdx);
}
gl.depthMask(true);
}
}

Expand Down
70 changes: 31 additions & 39 deletions src/webgl/WebGLStrategyUniform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -366,48 +366,40 @@ bool get_isBillboard(float instanceId) {
WebGLStrategyCommonMethod.setVRViewport(renderPass, displayIdx);
}

for (let j = 0; j < renderPass.drawCount; j++) {
renderPass.doPreEachDraw(j);

// For opaque primitives
if (renderPass.toRenderOpaquePrimitives) {
for (let i = 0; i <= renderPass._lastOpaqueIndex; i++) {
const primitiveUid = primitiveUids[i];
this.renderInner(
primitiveUid,
glw,
renderPass,
renderPassTickCount,
isVrMainPass,
displayIdx
);
}
// For opaque primitives
if (renderPass.toRenderOpaquePrimitives) {
for (let i = 0; i <= renderPass._lastOpaqueIndex; i++) {
const primitiveUid = primitiveUids[i];
this.renderInner(
primitiveUid,
glw,
renderPass,
renderPassTickCount,
isVrMainPass,
displayIdx
);
}
}

// For translucent primitives
if (renderPass.toRenderTransparentPrimitives) {
if (!MeshRendererComponent.isDepthMaskTrueForTransparencies) {
// disable depth write for transparent primitives
gl.depthMask(false);
}

// For translucent primitives
if (renderPass.toRenderTransparentPrimitives) {
if (!MeshRendererComponent.isDepthMaskTrueForTransparencies) {
// disable depth write for transparent primitives
gl.depthMask(false);
}

for (
let i = renderPass._lastOpaqueIndex + 1;
i <= renderPass._lastTransparentIndex;
i++
) {
const primitiveUid = primitiveUids[i];
this.renderInner(
primitiveUid,
glw,
renderPass,
renderPassTickCount,
isVrMainPass,
displayIdx
);
}
gl.depthMask(true);
for (let i = renderPass._lastOpaqueIndex + 1; i <= renderPass._lastTransparentIndex; i++) {
const primitiveUid = primitiveUids[i];
this.renderInner(
primitiveUid,
glw,
renderPass,
renderPassTickCount,
isVrMainPass,
displayIdx
);
}
gl.depthMask(true);
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/webgpu/WebGpuResourceRepository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import { GlobalDataRepository } from '../foundation/core/GlobalDataRepository';
import { RenderBuffer } from '../foundation/textures/RenderBuffer';
import { Vector2 } from '../foundation/math/Vector2';
import { CameraComponent } from '../foundation/components/Camera/CameraComponent';
import { EntityRepository } from '../foundation';
import { EntityRepository } from '../foundation/core/EntityRepository';

const HDRImage = require('../../vendor/hdrpng.min.js');

Expand Down
42 changes: 19 additions & 23 deletions src/webgpu/WebGpuStrategyBasic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@ import { CompositionType } from '../foundation/definitions/CompositionType';
import { ComponentType } from '../foundation/definitions/ComponentType';
import { ShaderSemantics, getShaderPropertyFunc } from '../foundation/definitions/ShaderSemantics';
import { ModuleManager } from '../foundation/system/ModuleManager';
import { WellKnownComponentTIDs } from '../foundation/components/WellKnownComponentTIDs';
import { ComponentRepository } from '../foundation/core/ComponentRepository';
import { CameraComponent } from '../foundation/components/Camera/CameraComponent';
import { VectorN } from '../foundation/math/VectorN';
import { RnXR } from '../xr/main';
import { Config } from '../foundation/core/Config';
import { VertexAttribute } from '../foundation/definitions/VertexAttribute';
Expand Down Expand Up @@ -298,7 +296,9 @@ ${indexStr}
);
}

if (BlendShapeComponent.updateCount !== this.__lastBlendShapeComponentsUpdateCountForBlendData) {
if (
BlendShapeComponent.updateCount !== this.__lastBlendShapeComponentsUpdateCountForBlendData
) {
this.__createOrUpdateStorageBlendShapeBuffer();
this.__lastBlendShapeComponentsUpdateCountForBlendData = BlendShapeComponent.updateCount;
}
Expand Down Expand Up @@ -388,30 +388,26 @@ ${indexStr}
renderPass: RenderPass,
renderPassTickCount: number
): boolean {
for (let j = 0; j < renderPass.drawCount; j++) {
renderPass.doPreEachDraw(j);

// For opaque primitives
if (renderPass.toRenderOpaquePrimitives) {
for (let i = 0; i <= renderPass._lastOpaqueIndex; i++) {
const primitiveUid = primitiveUids[i];
this.renderInner(primitiveUid, renderPass, renderPassTickCount);
}
// For opaque primitives
if (renderPass.toRenderOpaquePrimitives) {
for (let i = 0; i <= renderPass._lastOpaqueIndex; i++) {
const primitiveUid = primitiveUids[i];
this.renderInner(primitiveUid, renderPass, renderPassTickCount);
}
}

// For translucent primitives
if (renderPass.toRenderTransparentPrimitives) {
if (!MeshRendererComponent.isDepthMaskTrueForTransparencies) {
// disable depth write for transparent primitives
// gl.depthMask(false);
}
// For translucent primitives
if (renderPass.toRenderTransparentPrimitives) {
if (!MeshRendererComponent.isDepthMaskTrueForTransparencies) {
// disable depth write for transparent primitives
// gl.depthMask(false);
}

for (let i = renderPass._lastOpaqueIndex + 1; i <= renderPass._lastTransparentIndex; i++) {
const primitiveUid = primitiveUids[i];
this.renderInner(primitiveUid, renderPass, renderPassTickCount);
}
// gl.depthMask(true);
for (let i = renderPass._lastOpaqueIndex + 1; i <= renderPass._lastTransparentIndex; i++) {
const primitiveUid = primitiveUids[i];
this.renderInner(primitiveUid, renderPass, renderPassTickCount);
}
// gl.depthMask(true);
}

return true;
Expand Down
Loading