Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize math #1520

Merged
merged 5 commits into from
Jan 4, 2025
Merged

fix: optimize math #1520

merged 5 commits into from
Jan 4, 2025

Conversation

emadurandal
Copy link
Collaborator

No description provided.

Yuki Shimada added 5 commits January 5, 2025 02:55
- Added a new static temporary vector `__tmp_vec3_5` in the Quaternion class to improve performance.
- Updated `transformVector3` and `transformVector3To` methods to utilize the new temporary vector, reducing object creation overhead and enhancing efficiency in vector transformations.
…ormation methods

- Added `getPositionTo` and `getPositionRestTo` methods in SceneGraphComponent for improved position retrieval.
- Introduced `getRotationTo` method in SceneGraphComponent to facilitate quaternion rotation retrieval.
- Updated MutableMatrix44 with a new `getTranslateTo` method for enhanced translation handling.
- Modified VRMSpringBone to utilize `getTranslateTo` for world space calculations, improving performance and clarity.
- Added temporary vectors in VRMSpringBonePhysicsStrategy for optimized rotation and position calculations.
…vectors for optimized calculations

- Added new temporary vectors in VRMSpringBonePhysicsStrategy to improve position and rotation calculations.
- Updated methods to utilize the new vectors for enhanced performance and clarity in bone physics transformations.
- Introduced new temporary vectors in the Frustum class to streamline corner calculations.
- Replaced inline corner definitions with a dedicated private array for better organization and performance.
- Updated the corner calculation logic to utilize the new temporary vectors, enhancing efficiency and reducing object creation overhead.
…ector

- Introduced a new static temporary vector `__tmp_vec3_2_zero` in VRMSpringBone to enhance world space bone length calculations.
- Updated the `_calcWorldSpaceBoneLength` method to utilize the new temporary vector, improving performance and reducing object creation overhead.
@emadurandal emadurandal merged commit 05006a5 into main Jan 4, 2025
4 checks passed
@emadurandal emadurandal deleted the fix/optimize-math branch January 4, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant