Better testing #2125
Merged
Better testing #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plajjan
force-pushed
the
better-testing
branch
from
3b6c632 to
4d8b8d1
Compare
added 3 commits
January 27, 2025 12:28
- Now printing 'A: None' and not just 'None' for None values - the
if/else logic was wrong
- Changed default to always print values, even when custom error message
is set - this seem to make more sense to me, let's see
- added print_vals arg throughout for user to explicitly disable
printing values and just print the custom error message
- renamed assertIsTrue -> assertTrue & assertIsFalse -> assertFalse
- in Python, None, True and False are singletons so it is idiomatic to
use "is" "is not" but in Acton, they are not, None is C NULL and
True and False are their own objects, so let's not encourage is
checking these by having that in the assert names
- add test_testing project to show testing
- this is not run automatically, since the idea is to showcase errors,
which would then just fail CI
- but very useful for a human to look at stuff
If a test is using the logging library, those messages are now captured. Practically this happens simply by the test printing them to the console (stderr) where the test runner already captures messages.
Just to be run manually to inspect the output.
plajjan
force-pushed
the
better-testing
branch
from
4d8b8d1 to
54ebd04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.