Always let free() be Noop, Upgrade TLSUV and fix crashes #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2025 23:19
We should always do a noop_free. I think GC_free() is for leak detection, but we never use that so for all normal code we should just never free and instead let the GC do its job. This was prompted by free bugs related to TLS. I have not verified that this particular change fixes it, but I believe it is the correct thing to do.
This version implements multiple things we need, like custom allocators, so we can get rid of our own patches to tlsuv. The authmode patch remains. I put together a new build.zig too which more closely resembles the CMake config, although there still some Acton-related things. Above all, this appears to fix the TLS client so things are working properly again.
plajjan
force-pushed
the
tlsuv-upgrade
branch
from
37bdc9c to
50baf2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.