Fix transitive deps #2149
Merged
Fix transitive deps #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding transitive dependencies to the main project with a recursive search, do not override the main project dependencies. These can either be listed explicity in the main project build.act.json or passed on the command line with "--dep foo=../path/to/foo".
|
Very good! We don't really have test cases for package management. I don't think we should have automatic ones (I don't want CI to depend on Internet), but perhaps manual ones that one we can run when we actually modify this code. It is fairly self-contained I think so that would acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding transitive dependencies with a recursive search, do not override the main project dependencies. These can either be listed explicitly in the main project build.act.json or passed on the command line with "--dep foo=../path/to/foo".