Silence build lock for dependency builds #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is quite normal to have like ~diamond shaped dependencies in project, so the top project depends on A & B, and A also depends on B, so when we start sub-compilers to build dependencies, they will race to build B. One will make it first and the other will have to wait. It is unnecessary to print that build lock warning, it only confuses users (who think something has hung and aborts the whole build). Detecting this via TTY might not be ideal but it works for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite normal to have like ~diamond shaped dependencies in project, so the top project depends on A & B, and A also depends on B, so when we start sub-compilers to build dependencies, they will race to build B. One will make it first and the other will have to wait. It is unnecessary to print that build lock warning, it only confuses users (who think something has hung and aborts the whole build). Detecting this via TTY might not be ideal but it works for now.