Fix formatting quirks + migrate from webpack to Rollup
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of wasm-pack does not work well with webpack (the current bundler) so i moved to rollup.This requires the wasm module to be loaded "manually" and some changes in the way the format function is made availiable in the qleverUI.js file.
|
Note that this PR only changes how the wasm module is loaded and made availible in js. I switched from webpack to rollup since it worked for the new wasm binaries. However the installed "sparql-language-server" is a newer version (0.1.12) that addresses some formatting issues:
|
IoannisNezis
added
enhancement
hannahbast
approved these changes
Nov 25, 2024
hannahbast
changed the title
webpack to Rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of
wasm-packdoes not work well withwebpack(the current bundler), so we now takeRollupinstead. Thewasmmodule must now be loaded explicitly informatter/index.js. On the side, fix some quirks of the formatter regarding CONSTRUCT and FROM.