-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the disabling of websocket updates #1726
Allow the disabling of websocket updates #1726
Conversation
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1726 +/- ##
==========================================
+ Coverage 89.92% 89.93% +0.01%
==========================================
Files 393 393
Lines 37614 37595 -19
Branches 4231 4231
==========================================
- Hits 33823 33811 -12
+ Misses 2494 2485 -9
- Partials 1297 1299 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks. I will try this out end-to-end, add a description, and then merge this.
Conformance check passed ✅No test result changes. |
Quality Gate passedIssues Measures |
The websocket updates (for the live updates of the "Analysis" tree) can significantly slow down queries with very many cheap operations. This change adds a runtime parameter
websocket-updates-enabled
for controlling whether websocket updates should be performed or not.