Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the disabling of websocket updates #1726

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Jan 21, 2025

The websocket updates (for the live updates of the "Analysis" tree) can significantly slow down queries with very many cheap operations. This change adds a runtime parameter websocket-updates-enabled for controlling whether websocket updates should be performed or not.

Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.93%. Comparing base (ff47922) to head (517c7ef).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/Operation.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
+ Coverage   89.92%   89.93%   +0.01%     
==========================================
  Files         393      393              
  Lines       37614    37595      -19     
  Branches     4231     4231              
==========================================
- Hits        33823    33811      -12     
+ Misses       2494     2485       -9     
- Partials     1297     1299       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks. I will try this out end-to-end, add a description, and then merge this.

@hannahbast hannahbast changed the title Allow the disabling of websocket updates. Allow the disabling of websocket updates Jan 23, 2025
@sparql-conformance
Copy link

@hannahbast hannahbast merged commit d79cf60 into ad-freiburg:master Jan 24, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants