Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce ADA_USE_UNSAFE_STD_REGEX_PROVIDER flag for security #853

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jan 27, 2025

Let's put std_regex_provider under a flag.

@anonrig anonrig requested a review from lemire January 27, 2025 20:25
@anonrig anonrig force-pushed the yagiz/put-std-regex-under-flag branch from c6d3674 to 2dc94cc Compare January 27, 2025 20:29
@anonrig anonrig requested a review from jasnell January 27, 2025 20:29
@anonrig anonrig force-pushed the yagiz/put-std-regex-under-flag branch from 2dc94cc to f040330 Compare January 27, 2025 20:31
@anonrig anonrig force-pushed the yagiz/put-std-regex-under-flag branch from f040330 to 9b1ff22 Compare January 27, 2025 20:40
@anonrig anonrig force-pushed the yagiz/put-std-regex-under-flag branch from 9b1ff22 to b3b3f07 Compare January 27, 2025 20:45
@anonrig anonrig force-pushed the yagiz/put-std-regex-under-flag branch from b3b3f07 to da023fb Compare January 27, 2025 21:00
@anonrig
Copy link
Member Author

anonrig commented Jan 27, 2025

@lemire any objections on landing this? the fuzzing errors will be gone when it's merged.

Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection.

@anonrig anonrig merged commit ea07694 into main Jan 27, 2025
38 of 41 checks passed
@anonrig anonrig deleted the yagiz/put-std-regex-under-flag branch January 27, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants