Skip to content

Commit

Permalink
Merge pull request #67 from justmobilize/build-test
Browse files Browse the repository at this point in the history
Build tools update
  • Loading branch information
dhalbert authored Mar 20, 2024
2 parents 046321a + d4751e7 commit 212ce2c
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 13 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,18 @@ jobs:
tr '_' '-'
)" >> $GITHUB_OUTPUT
- name: Set up Python 3.x
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: "3.x"
- name: Versions
run: |
python3 --version
- name: Checkout Current Repo
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
submodules: true
- name: Checkout tools repo
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: adafruit/actions-ci-circuitpython-libs
path: actions-ci
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,18 @@ jobs:
tr '_' '-'
)" >> $GITHUB_OUTPUT
- name: Set up Python 3.x
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: "3.x"
- name: Versions
run: |
python3 --version
- name: Checkout Current Repo
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
submodules: true
- name: Checkout tools repo
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: adafruit/actions-ci-circuitpython-libs
path: actions-ci
Expand All @@ -55,16 +55,16 @@ jobs:
upload-pypi:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Check For pyproject.toml
id: need-pypi
run: |
echo "pyproject-toml=$( find . -wholename './pyproject.toml' )" >> $GITHUB_OUTPUT
- name: Set up Python
if: contains(steps.need-pypi.outputs.pyproject-toml, 'pyproject.toml')
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.x'
python-version: "3.x"
- name: Install dependencies
if: contains(steps.need-pypi.outputs.pyproject-toml, 'pyproject.toml')
run: |
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ repos:
- id: end-of-file-fixer
- id: trailing-whitespace
- repo: https://github.com/pycqa/pylint
rev: v2.17.4
rev: v3.1.0
hooks:
- id: pylint
name: pylint (library code)
Expand Down
8 changes: 5 additions & 3 deletions _bleio/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ def name(self) -> str:
def name(self, value: str) -> None:
self._name = value

# pylint: disable=too-many-arguments
def start_advertising(
self,
data: Buf,
Expand All @@ -196,6 +197,7 @@ def stop_advertising(self) -> None:
"""Stop sending advertising packets."""
raise NotImplementedError("Advertising not implemented")

# pylint: disable=too-many-arguments
def start_scan(
self,
prefixes: Buf = b"",
Expand Down Expand Up @@ -234,13 +236,12 @@ def start_scan(
self._clear_device_cache()

if self._use_hcitool:
for scan_entry in self._start_scan_hcitool(
yield from self._start_scan_hcitool(
prefixes,
timeout=timeout,
minimum_rssi=minimum_rssi,
active=active,
):
yield scan_entry
)
return

self._scanning_in_progress = True
Expand Down Expand Up @@ -459,6 +460,7 @@ class Characteristic:
WRITE_NO_RESPONSE = 0x20
"""property: clients may write this characteristic; no response will be sent back"""

# pylint: disable=too-many-arguments
def __init__(
self,
*,
Expand Down
2 changes: 2 additions & 0 deletions _bleio/descriptor.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class Descriptor:
Descriptors are attached to BLE characteristics and provide contextual
information about the characteristic."""

# pylint: disable=too-many-arguments
def __init__(
self,
*,
Expand All @@ -52,6 +53,7 @@ def __init__(
self._characteristic = None
self._bleak_gatt_descriptor = None

# pylint: disable=too-many-arguments
@classmethod
def add_to_characteristic(
cls,
Expand Down
1 change: 1 addition & 0 deletions _bleio/scan_entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class ScanEntry:
re.IGNORECASE,
)

# pylint: disable=too-many-arguments
def __init__(
self,
*,
Expand Down

0 comments on commit 212ce2c

Please sign in to comment.