New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secrets usage #129

Merged

dhalbert merged 1 commit into adafruit:main from justmobilize:remove-secrets-usage

Feb 24, 2025

Contributor

justmobilize commented Feb 23, 2025

Remove usage of secrets and more:

change from using secrets.py to os.getenv
switch from ESPSPI_WiFiManager to WiFiManager
update pool, ssl_context setting to use adafruit_connection_manager like all the other examples


          Remove secrets usage

ea7c397

justmobilize marked this pull request as ready for review

February 23, 2025 16:31

Contributor Author

justmobilize commented Feb 23, 2025

@dhalbert and @tyeth cleaned up all the examples!

dhalbert requested review from tyeth and brentru

February 23, 2025 18:02

brentru approved these changes

View reviewed changes

Member

brentru left a comment

@justmobilize That was a lot of examples! This pull request looks good and the code reflects the changes you mentioned.

Contributor Author

justmobilize commented Feb 24, 2025

It sure was. There are 100s of files I need to update to remove all the instances of secrets across example and the learn guide...

dhalbert merged commit 7e8f3c5 into adafruit:main

1 check passed

justmobilize deleted the remove-secrets-usage branch

February 24, 2025 16:58

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@761055f)

7cd52f5

Updating https://github.com/adafruit/Adafruit_CircuitPython_ACeP7In to 1.0.0 from 0.8.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_ACeP7In#7 from FoamyGuy/remove_8x_displayio

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1106 to 2.0.0 from 1.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1106#22 from FoamyGuy/ruff_and_remove_8x_compat

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 2.0.0 from 1.7.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#26 from FoamyGuy/use_ruff_remove_8x_compatibility

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 3.0.0 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#50 from FoamyGuy/use_ruff_and_remove_8x_compat

Updating https://github.com/adafruit/Adafruit_CircuitPython_EK79686 to 2.0.0 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_EK79686#2 from FoamyGuy/use_ruff_remove_8x_compat

Updating https://github.com/adafruit/Adafruit_CircuitPython_HX8357 to 2.0.0 from 1.4.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_HX8357#25 from FoamyGuy/use_ruff_and_remove_8x_compat

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 2.0.0 from 1.4.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#33 from FoamyGuy/use_ruff_remove_8x_compat

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 2.0.0 from 1.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#20 from FoamyGuy/use_ruff_remove_8x_compat

Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 2.0.0 from 1.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#41 from FoamyGuy/use_ruff_remove_8x_compat

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 2.0.0 from 1.5.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#20 from FoamyGuy/use_ruff_remove_8x_compat

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1331 to 2.0.0 from 1.4.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1331#19 from FoamyGuy/use_ruff_remove_8x_comat

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 2.0.0 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#19 from FoamyGuy/use_ruff_remove_8x_comapt

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 6.0.0 from 5.10.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#129 from justmobilize/remove-secrets-usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet