Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where if category is out of bounds it was crashing #43

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

makermelissa
Copy link
Collaborator

John had a crash with this error:

Traceback (most recent call last):
  File "code.py", line 176, in <module>
  File "code.py", line 152, in <module>
  File "/lib/adafruit_ble/services/apple.py", line 154, in __str__
TypeError: can't convert 'NoneType' object to str implicitly

I know, old version. However, there was still the possible condition to cause this. According to https://developer.apple.com/library/archive/documentation/CoreBluetooth/Reference/AppleNotificationCenterServiceSpecification/Appendix/Appendix.html, it should be marked Reserved, so I just made the string be reserved.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@makermelissa makermelissa requested a review from a team December 11, 2019 03:20
@makermelissa makermelissa merged commit 26325f6 into adafruit:master Dec 11, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 11, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 3.1.1 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#43 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 1.0.0 from 0.8.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#8 from kattni/animations
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#7 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#5 from demophoon/add-blinka-to-requirements-txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants