Expose individual brightness modification in stock dotstar library #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcscope
force-pushed
the
advanced_dotstar
branch
3 times, most recently
from
702403a to
133574c
Compare
mcscope
changed the title
|
@tannewt Please review! |
tannewt
approved these changes
May 14, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 16, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 1.2.0 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#20 from mcscope/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#19 from mcscope/advanced_dotstar > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#18 from mcscope/color_orders > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#17 from margaret/consistent_get_set > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#14 from sommersoft/new_docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can't use the per-pixel brightness byte in stock DotStar, because the API should match NeoPixels and NeoPixels don't have per-pixel brightness values.This is a new class, Advanced Dotstar, that uses these features. You only need to import it if you want it's features, so hopefully it saves our users some ram hit.Turns out we can't easily bundle multiple files in one of these modules, so I've integrated my functionality into the main DotStar class.
Fufills issue: #16