New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid secret lookup #12

Merged

dhalbert merged 1 commit into adafruit:main from justmobilize:fix-invalid-secret-lookup

Feb 25, 2025

Contributor

justmobilize commented Feb 25, 2025 •

edited

Loading

Remove using self._secrets which was removed from NetworkBase of PortalBase in v1.15.0


          Fix invalid secret lookup

ed93b82

justmobilize marked this pull request as ready for review

February 25, 2025 14:53

Contributor Author

justmobilize commented Feb 25, 2025

@dhalbert small fix for a bug I found while looking for secrets.

dhalbert approved these changes

View reviewed changes

Contributor

dhalbert left a comment

Good sleuthing, thanks!

dhalbert merged commit d37a7ff into adafruit:main

1 check passed

justmobilize deleted the fix-invalid-secret-lookup branch

February 25, 2025 16:09

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@761055f)

386ee84

Updating https://github.com/adafruit/Adafruit_CircuitPython_FONA to 3.0.7 from 3.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_FONA#33 from justmobilize/remove-secrets-usage

Updating https://github.com/adafruit/Adafruit_CircuitPython_OV2640 to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV2640#29 from justmobilize/remove-secrets-usage

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 7.2.2 from 7.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#176 from justmobilize/remove-secrets

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32S2TFT to 2.0.0 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32S2TFT#12 from justmobilize/fix-invalid-secret-lookup

Updating https://github.com/adafruit/Adafruit_CircuitPython_Hue to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Hue#25 from justmobilize/remove-secrets-usage

Updating https://github.com/adafruit/Adafruit_CircuitPython_JWT to 1.2.20 from 1.2.19:
  > Merge pull request adafruit/Adafruit_CircuitPython_JWT#17 from justmobilize/remove-secrets-usage

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 3.0.1 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#26 from justmobilize/remove-secrets

Updating https://github.com/adafruit/Adafruit_CircuitPython_OAuth2 to 1.0.20 from 1.0.19:
  > Merge pull request adafruit/Adafruit_CircuitPython_OAuth2#13 from justmobilize/remove-secrets

Updating https://github.com/adafruit/Adafruit_CircuitPython_Pastebin to 1.0.8 from 1.0.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_Pastebin#4 from justmobilize/remove-secrets

Updating https://github.com/adafruit/Adafruit_CircuitPython_Qualia to 2.0.0 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Qualia#8 from justmobilize/fix-invalid-secret-lookup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet