Add Temperature Oversampling #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
requested changes
Feb 12, 2025
| @@ -247,6 +249,7 @@ def __init__( # pylint: disable=too-many-arguments | |||
| # Set gain to the supplied level | |||
| self.gain = self._gain_current | |||
| self.temperature_compensation = self._temperature_compensation | |||
| self.temperature_oversampling = self._osr2 | |||
There was a problem hiding this comment.
Does self.temperature_oversampling need to get set here? It seems like the getter/setter properties will override this immediately. Maybe we can remove it here inside of init.
There was a problem hiding this comment.
I was just copying what all the other settings were doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #22 but for temperature oversampling.
The
0xE7FFmask comes from manipulating bits 12 and 13 of the register: so1110 0111 1111 1111in hexThe internal OSR2 name is what the datasheet calls this parameter. No reason to have separate settings for this as it uses the same values as the existing OSR ones.
@FoamyGuy could you review?