Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various enhancements #15

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Various enhancements #15

merged 7 commits into from
Jan 5, 2024

Conversation

jepler
Copy link
Member

@jepler jepler commented Jan 4, 2024 •
edited
Loading

  • Factor out a PyCameraBase class that doesn't have the full camera UI etc
  • Hook up the display backlight PWM pin so pycam.display.brightness works
  • Speed up autofocus init by sending the firmware in 254-byte chunks
  • Allow the display blit to set a different Y-offset
  • Add an image viewer application -- cycles every 8s, or allows navigation with directional buttons
  • Avoid deprecation warnings. We can use the 9x-only alternatives since this board doesn't work with 8.x

jepler added 7 commits January 4, 2024 11:16
@jepler
Factor out a PyCameraBase class
0aa1814 
This gives the coder control over what is initialized. For the image
review app, for instance, the camera & autofocus would not be initialized.

Support for the display backlight is also added.
@jepler
Speed up autofocus init
c3a682a 
The firmware can be written in 254-byte chunks, and it's much
speedier.
@jepler
Ensure the splash group always exists
512efd8 
so we can call pycam.display_message even without the rest of the camera
ui
@jepler
Allow setting X & Y offsets for the direct bitmap blit
82d2335 
this is useful for apps that don't have the top/bottom area reserved
@jepler
Add an image viewer application
6da6447
@jepler
Avoid deprecation warnings
63bef16
@jepler
fix doc build
05dc862
@jepler
Copy link
Member Author

jepler commented Jan 4, 2024

@brentru with this PR it should be possible to set pycam.display.brightness.

brentru
brentru approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jepler LGTM - removal of autofocus_init is in the right spots too. Please feel free to merge and release when ready.

@jepler jepler merged commit 16530b5 into main Jan 5, 2024
2 checks passed
@jepler jepler deleted the enhancements branch January 5, 2024 01:02
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 9, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@2959bae)
212aaf0 
Updating https://github.com/adafruit/Adafruit_CircuitPython_24LC32 to 1.1.0 from 1.0.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_24LC32#23 from TonyLHansen/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 2.0.0 from 1.3.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#24 from jposada202020/improving_lib

Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 3.1.0 from 3.0.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#61 from prcutler/root-group-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.4.14 from 3.4.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#59 from bdlucas1/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.8.1 from 5.8.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#114 from kavinaidoo/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 1.3.0 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#59 from imnotjames/chore/optional-traceback

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 0.0.7 from 0.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#15 from adafruit/enhancements
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#13 from brentru/allow-jpg-save

Updating https://github.com/adafruit/Adafruit_CircuitPython_TemplateEngine to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TemplateEngine#2 from michalpokusa/removing-8-x-x-re-module-bug-workarounds

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @brentru