Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding_references #11

Merged
merged 2 commits into from
Jun 4, 2021
Merged

adding_references #11

merged 2 commits into from
Jun 4, 2021

Conversation

jposada202020
Copy link
Contributor

@jposada202020 jposada202020 commented May 3, 2021 •
edited
Loading

[X] Verify that note in all the board.I2C references are present (Readme, examples and code)
[x] Change hardware description XXX_
[x] Change Circuit Python references Software and Dependencies:
[x] If library uses SPI verify that digitalio import is included
[X] Verify that learning guide is included
[X] Verify that product is included

@jposada202020 jposada202020 requested a review from kattni May 3, 2021 17:17
@jposada202020 jposada202020 self-assigned this May 3, 2021
@jposada202020
Copy link
Contributor Author

@kattni could you take a look, this was done when we were doing the documentation improvements but was left out for some reason. thanks :)

KeithTheEE
KeithTheEE approved these changes Jun 4, 2021
View reviewed changes
Copy link

@KeithTheEE KeithTheEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. All of the hyperlinks work, one to the sensor and two to the necessary libraries. The formatting looks clean as well.

@jposada202020
Copy link
Contributor Author

@CrakeNotSnowman Thanks for the review :) really appreciated 👍🏼

@jposada202020 jposada202020 merged commit bc98be7 into adafruit:master Jun 4, 2021
@KeithTheEE
Copy link

No problem! Still learning what to look for with respect to the process--I'm still making my way through the learn guides, but I'm happy to help! Thanks for asking for it!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 8, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@671d282)
07ad4ac 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.5 from 2.6.4:
  > Moved default branch to main
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#52 from jposada202020/memory_otimization
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTU31D to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTU31D#6 from gmparis/main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.0.8 from 2.0.7:
  > Linted
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.0 from 4.0.6:
  > Moved default branch to main
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#42 from danielballan/nonblocking
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_L3GD20 to 2.3.6 from 2.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#23 from jposada202020/correcting_measuremnt_units
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.1.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#4 from CrakeNotSnowman/voc_algorithm_dev
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.1.2 from 1.1.1:
  > Moved default branch to main
  > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#11 from jposada202020/master
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI4713 to 1.3.2 from 1.3.1:
  > Moved default branch to main
  > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#20 from jposada202020/solving_station_information

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.11.6 from 2.11.5:
  > Corrected url
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#64 from jposada202020/correcting_example_link

Updating https://github.com/adafruit/Adafruit_CircuitPython_Colorsys to 2.0.1 from 2.0.0:
  > Moved default branch to main
  > Merge pull request adafruit/Adafruit_CircuitPython_Colorsys#17 from GomiHgy/patch-1
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.1.4 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#17 from jposada202020/adding_new_guides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeithTheEE KeithTheEE KeithTheEE approved these changes

@kattni kattni Awaiting requested review from kattni

Assignees

@jposada202020 jposada202020

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jposada202020 @KeithTheEE