Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating colstart kwarg #14

Merged
merged 1 commit into from
Feb 24, 2023
Merged

updating colstart kwarg #14

merged 1 commit into from
Feb 24, 2023

Conversation

jposada202020
Copy link
Contributor

Tested on

Adafruit CircuitPython 8.0.0 on 2023-02-06; Adafruit Feather RP2040 with rp2040
When adding the colstart=8. Image is correctly displayed

image

makermelissa
makermelissa approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking and updating.

@makermelissa makermelissa merged commit 82cb716 into adafruit:main Feb 24, 2023
@jposada202020 jposada202020 deleted the updating_example branch February 24, 2023 18:24
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 28, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@2415fa6)
0300f10 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.6.0 from 1.5.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#31 from dglaude/0.49''-64-x-32
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 3.3.7 from 3.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#53 from EAGrahamJr/fade_52
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_PN532 to 2.3.16 from 2.3.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_PN532#63 from caternuson/iss44
  > Merge pull request adafruit/Adafruit_CircuitPython_PN532#62 from caternuson/iss49
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 2.1.14 from 2.1.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#44 from jerryneedell/jerryn_size
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.1.16 from 1.1.15:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#14 from jposada202020/updating_example
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.0.14 from 1.0.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#12 from jposada202020/adding_breakout_example
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#11 from jposada202020/main
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#9 from dave-ct/128
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.2.0 from 1.1.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#23 from rtwfroody/invert
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_AirLift to 1.0.9 from 1.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_AirLift#8 from glenrobertson/patch-1
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.7.0 from 2.6.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#105 from FoamyGuy/multicolor_comet

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 3.0.11 from 3.0.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#88 from Lnk2past/master
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.3.1 from 7.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#156 from vladak/suback_var_payload
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#153 from vladak/back_off_tests

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
@tannewt
Copy link
Member

tannewt commented Mar 22, 2023

@jposada202020 When did you buy this? The display was update to a SSD1680. I have an older version with a SSD1675 and it needs colstart=0. The ribbon cable has 1852 written on a portion of it.

@makermelissa
Copy link
Collaborator

Good point. I believe this is the newer one because it only has 1 tab on the left, whereas the older ones have 2 tabs.

@jposada202020
Copy link
Contributor Author

Probably less than 2 months ago. However this comes from digikey. I could take a picture of the ribbon and/or change the example accordingly. Let me know

@tannewt
Copy link
Member

tannewt commented Mar 23, 2023

@jposada202020 Please change this example back and add an example (if there isn't) to the SSD1680 repo. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jposada202020 @tannewt @makermelissa