Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use open-drain capabilities on GPIO; clean up board init; set correct GPIO voltage #1177

Merged
merged 1 commit into from
Sep 10, 2018
Merged

use open-drain capabilities on GPIO; clean up board init; set correct GPIO voltage #1177

merged 1 commit into from
Sep 10, 2018

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Sep 9, 2018 •
edited
Loading

  • Use native GPIO capabilities in common-hal/digitalio/DigitalInOut.c instead of simulating open drain outputs with inputs.
  • Make sure GPIO voltage is 3.3V. It will be 1.8V if UICR->REGOUT0 has been cleared.
  • Some refactoring of board_init() into other places.
  • Make sure instruction cache is on. SoftDevice is supposed to turn it on, but let's make sure.

tannewt
tannewt approved these changes Sep 10, 2018
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@tannewt tannewt merged commit 9ace50a into adafruit:master Sep 10, 2018
@dhalbert dhalbert deleted the gpio-fixs branch September 12, 2018 16:54
@dhalbert dhalbert mentioned this pull request Sep 17, 2018
Closed
@dhalbert
Copy link
Collaborator Author

Fixes #1174.

@dhalbert
Copy link
Collaborator Author

Fixes #1151.

@dhalbert dhalbert mentioned this pull request Sep 17, 2018
Closed
@jerryneedell jerryneedell mentioned this pull request Feb 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@arturo182 arturo182 Awaiting requested review from arturo182

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt